Attention is currently required from: Furquan Shaikh, Kane Chen, Karthik Ramasubramanian.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52873 )
Change subject: soc/intel/{adl,tgl,jsl}: Add smihandler_soc_disable_busmaster
......................................................................
Patch Set 5: Code-Review+2
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52873/comment/af0fc47b_89f4520a
PS5, Line 20:
nit: `TEST=...` please add how you tested this
File src/soc/intel/alderlake/smihandler.c:
https://review.coreboot.org/c/coreboot/+/52873/comment/35c79c5e_c3e97d19
PS5, Line 28: {
a small comment referencing why this is done at the top of these functions would be helpful
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52873
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1cf5cf91ebad4a49df6679e01fc88ff60c81526c
Gerrit-Change-Number: 52873
Gerrit-PatchSet: 5
Gerrit-Owner: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Rasheed Hsueh
rasheed.hsueh@lcfc.corp-partner.google.com
Gerrit-CC: Stanley Wu
stanley1.wu@lcfc.corp-partner.google.com
Gerrit-CC: Sunshine Chao
sunshine.chao@lcfc.corp-partner.google.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Kane Chen
kane.chen@intel.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Wed, 05 May 2021 21:03:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment