Change in coreboot[master]: drivers/intel/mipi_camera: Generate SSDT for camera

[Matt Delco (Code Review)]

Matt Delco has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41607 )

Change subject: drivers/intel/mipi_camera: Generate SSDT for camera
......................................................................

Patch Set 19:

(2 comments)

https://review.coreboot.org/c/coreboot/+/41607/19/src/drivers/intel/mipi_cam... 
File src/drivers/intel/mipi_camera/camera.c:

https://review.coreboot.org/c/coreboot/+/41607/19/src/drivers/intel/mipi_cam... 
PS19, Line 49: config->cio2_num_ports
I wonder if it's worth be paranoid about the case where cio2_num_ports > MAX_PORT_ENTRIES.

https://review.coreboot.org/c/coreboot/+/41607/19/src/drivers/intel/mipi_cam... 
PS19, Line 205: 3 + (config->ssdb.vcm_type ? 1 : 0)
As food for thought, it'd be simpler to use "local1_ret + 1", which is simpler but probably harder for someone to follow (so it might not be a worthwhile change).  I had considered whether to use another variable like:

int next_local1 = 1;

and then each of the 4 instances of acpigen_write_if_lequal_op_int() would do:

acpigen_write_if_lequal_op_int(LOCAL1_OP, next_local1++);