Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41815 )
Change subject: console: Update for vboot before bootblock
......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/41815/6/src/console/init.c
File src/console/init.c:
https://review.coreboot.org/c/coreboot/+/41815/6/src/console/init.c@70
PS6, Line 70: CONFIG(EARLY_PCI_BRIDGE)
Well, we can use early EARLY_PCI_BRIDGE on the system with VBOOT_STARTS_BEFORE_BOOTBLOCK, just not i […]
Looking at the other comments around it seems that you don't want to use coreboot's
console drivers at all? If that is the case, why go through all the trouble and run
console_init()? Might be that this is the one line that gives you a build error but
it seems there is more that you'd want to skip?
https://review.coreboot.org/c/coreboot/+/41815/6/src/console/init.c@71
PS6, Line 71: !(CONFIG(VBOOT_STARTS_BEFORE_BOOTBLOCK) && ENV_SEPARATE_VERSTAGE))
Doesn't the former imply the latter?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41815
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifc9fb0810e0816fe0a68e52287eda6145043a619
Gerrit-Change-Number: 41815
Gerrit-PatchSet: 6
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Eric Peers
epeers@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 10 Jun 2020 17:17:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment