Change in ...coreboot[master]: mb/lenovo/t420s/smihandler: Remove unused include

List overview All Threads
Download

newer

older

Change in ...coreboot[master]:...

Peter Lemenkov (Code Review)

15 Jun 2019 15 Jun '19

11:31 a.m.

Peter Lemenkov has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33510

Change subject: mb/lenovo/t420s/smihandler: Remove unused include ......................................................................

mb/lenovo/t420s/smihandler: Remove unused include

All usage of pci_read_config8 was removed in commit d44d4f0f with Change-Id Ia959eb5b747846048396e66d4c926c96c27f3878 ("mb/lenovo/*: Remove useless smihandler code"). So we don't need this include anymore.

Change-Id: Ic4f038c80e17799016ae7e92a5675cfe7c71e400 Signed-off-by: Peter Lemenkov lemenkov@gmail.com --- M src/mainboard/lenovo/t420s/smihandler.c 1 file changed, 0 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/33510/1

diff --git a/src/mainboard/lenovo/t420s/smihandler.c b/src/mainboard/lenovo/t420s/smihandler.c index 2713725..bc72a12 100644 --- a/src/mainboard/lenovo/t420s/smihandler.c +++ b/src/mainboard/lenovo/t420s/smihandler.c @@ -16,7 +16,6 @@ */

#include <arch/io.h> -#include <device/pci_ops.h> #include <console/console.h> #include <cpu/x86/smm.h> #include <ec/acpi/ec.h>

Attachments:

attachment.htm (text/html — 2.5 KB)

Show replies by date

Arthur Heymans (Code Review)

15 Jun 15 Jun

11:41 a.m.

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33510 )

Change subject: mb/lenovo/t420s/smihandler: Remove unused include ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/33510 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic4f038c80e17799016ae7e92a5675cfe7c71e400 Gerrit-Change-Number: 33510 Gerrit-PatchSet: 1 Gerrit-Owner: Peter Lemenkov lemenkov@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sat, 15 Jun 2019 18:41:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Peter Lemenkov (Code Review)

11:45 a.m.

New subject: Change in ...coreboot[master]: mb/lenovo/*/smihandler: Remove unused include

Hello Arthur Heymans, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33510

to look at the new patch set (#2).

Change subject: mb/lenovo/*/smihandler: Remove unused include ......................................................................

mb/lenovo/*/smihandler: Remove unused include

Change-Id: Ic4f038c80e17799016ae7e92a5675cfe7c71e400 Signed-off-by: Peter Lemenkov lemenkov@gmail.com --- M src/mainboard/lenovo/t420s/smihandler.c M src/mainboard/lenovo/t430s/smihandler.c M src/mainboard/lenovo/t520/smihandler.c M src/mainboard/lenovo/t530/smihandler.c M src/mainboard/lenovo/x220/smihandler.c 5 files changed, 0 insertions(+), 5 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/33510/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/33510 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic4f038c80e17799016ae7e92a5675cfe7c71e400 Gerrit-Change-Number: 33510 Gerrit-PatchSet: 2 Gerrit-Owner: Peter Lemenkov lemenkov@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Angel Pons (Code Review)

5:36 p.m.

New subject: Change in ...coreboot[master]: mb/lenovo/*/smihandler: Remove unused include

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33510 )

Change subject: mb/lenovo/*/smihandler: Remove unused include ......................................................................

Patch Set 2: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/33510 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic4f038c80e17799016ae7e92a5675cfe7c71e400 Gerrit-Change-Number: 33510 Gerrit-PatchSet: 2 Gerrit-Owner: Peter Lemenkov lemenkov@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sun, 16 Jun 2019 00:36:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

16 Jun 16 Jun

12:58 a.m.

New subject: Change in ...coreboot[master]: mb/lenovo/*/smihandler: Remove unused include

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33510 )

Change subject: mb/lenovo/*/smihandler: Remove unused include ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/33510 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic4f038c80e17799016ae7e92a5675cfe7c71e400 Gerrit-Change-Number: 33510 Gerrit-PatchSet: 2 Gerrit-Owner: Peter Lemenkov lemenkov@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sun, 16 Jun 2019 07:58:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Arthur Heymans (Code Review)

1:09 a.m.

New subject: Change in ...coreboot[master]: mb/lenovo/*/smihandler: Remove unused include

Arthur Heymans has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33510 )

Change subject: mb/lenovo/*/smihandler: Remove unused include ......................................................................

mb/lenovo/*/smihandler: Remove unused include

Change-Id: Ic4f038c80e17799016ae7e92a5675cfe7c71e400 Signed-off-by: Peter Lemenkov lemenkov@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/33510 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: HAOUAS Elyes ehaouas@noos.fr --- M src/mainboard/lenovo/t420s/smihandler.c M src/mainboard/lenovo/t430s/smihandler.c M src/mainboard/lenovo/t520/smihandler.c M src/mainboard/lenovo/t530/smihandler.c M src/mainboard/lenovo/x220/smihandler.c 5 files changed, 0 insertions(+), 5 deletions(-)

Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved Angel Pons: Looks good to me, but someone else must approve

#include <arch/io.h> -#include <device/pci_ops.h> #include <console/console.h> #include <cpu/x86/smm.h> #include <ec/acpi/ec.h> diff --git a/src/mainboard/lenovo/t430s/smihandler.c b/src/mainboard/lenovo/t430s/smihandler.c index 2810e5a..f06eaf7 100644 --- a/src/mainboard/lenovo/t430s/smihandler.c +++ b/src/mainboard/lenovo/t430s/smihandler.c @@ -16,7 +16,6 @@ */

#include <arch/io.h> -#include <device/pci_ops.h> #include <console/console.h> #include <cpu/x86/smm.h> #include <ec/acpi/ec.h> diff --git a/src/mainboard/lenovo/t520/smihandler.c b/src/mainboard/lenovo/t520/smihandler.c index 46ad664..35a26c0 100644 --- a/src/mainboard/lenovo/t520/smihandler.c +++ b/src/mainboard/lenovo/t520/smihandler.c @@ -16,7 +16,6 @@ */

#include <arch/io.h> -#include <device/pci_ops.h> #include <console/console.h> #include <cpu/x86/smm.h> #include <ec/acpi/ec.h> diff --git a/src/mainboard/lenovo/t530/smihandler.c b/src/mainboard/lenovo/t530/smihandler.c index 46ad664..35a26c0 100644 --- a/src/mainboard/lenovo/t530/smihandler.c +++ b/src/mainboard/lenovo/t530/smihandler.c @@ -16,7 +16,6 @@ */

#include <arch/io.h> -#include <device/pci_ops.h> #include <console/console.h> #include <cpu/x86/smm.h> #include <ec/acpi/ec.h> diff --git a/src/mainboard/lenovo/x220/smihandler.c b/src/mainboard/lenovo/x220/smihandler.c index 46ad664..35a26c0 100644 --- a/src/mainboard/lenovo/x220/smihandler.c +++ b/src/mainboard/lenovo/x220/smihandler.c @@ -16,7 +16,6 @@ */

#include <arch/io.h> -#include <device/pci_ops.h> #include <console/console.h> #include <cpu/x86/smm.h> #include <ec/acpi/ec.h>

-- To view, visit https://review.coreboot.org/c/coreboot/+/33510 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic4f038c80e17799016ae7e92a5675cfe7c71e400 Gerrit-Change-Number: 33510 Gerrit-PatchSet: 3 Gerrit-Owner: Peter Lemenkov lemenkov@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

1980

days inactive

1981

days old

coreboot-gerrit@coreboot.org

5 comments

4 participants

tags (0)

participants (4)

Angel Pons (Code Review)
Arthur Heymans (Code Review)
HAOUAS Elyes (Code Review)
Peter Lemenkov (Code Review)