Attention is currently required from: Mario Scheithauer, Werner Zeh.
Jan Samek has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69543 )
Change subject: drivers/i2c/rv3028c7: Add ACPI generation callbacks
......................................................................
Patch Set 1:
(1 comment)
File src/drivers/i2c/rv3028c7/chip.h:
https://review.coreboot.org/c/coreboot/+/69543/comment/5a1415ca_4098896d
PS1, Line 38: unsigned int bus_speed; /* Bus clock in Hz (default 400 kHz) */
The term 'default' here means the default speed the DW-I2C controller uses. In dw_i2c. […]
[After a direct discussion with Werner] it's clear that there's no direct relation with dw_i2c and this comment should be removed (also from RX6110 driver) to avoid further confusion.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69543
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3b8cf5c8dc551439755992ff05b6693e91cc3f21
Gerrit-Change-Number: 69543
Gerrit-PatchSet: 1
Gerrit-Owner: Jan Samek
jan.samek@siemens.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-CC: Johannes Hahn
johannes-hahn@siemens.com
Gerrit-CC: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-CC: Uwe Poeche
uwe.poeche@siemens.com
Gerrit-Attention: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Comment-Date: Mon, 14 Nov 2022 15:47:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Werner Zeh
werner.zeh@siemens.com
Comment-In-Reply-To: Jan Samek
jan.samek@siemens.com
Gerrit-MessageType: comment