Attention is currently required from: Felix Singer, Jamie Ryu, Wonkyu Kim, Ethan Tsao, Ravishankar Sarawadi, Paul Menzel, Angel Pons, Raj Astekar.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62772 )
Change subject: soc/intel/mtl: Do initial Meteor Lake SoC commit till bootblock
......................................................................
Patch Set 10: Code-Review+1
(1 comment)
File src/soc/intel/meteorlake/bootblock/bootblock.c:
https://review.coreboot.org/c/coreboot/+/62772/comment/a30f2e46_0c8ae284
PS10, Line 20: bootblock_pch_early_init();
: ioe_p2sb_enable_bar();
: fast_spi_cache_bios_region();
: pch_early_iorange_init();
can you please try to logically separate these functions as in
1. bootblock_pch_early_init -> bootblock_soc_early_init (as MTL doesn't have PCH die anymore)
2. ioe_p2sb_enable_bar -> bootblock_ioe_early_init
3. move ioe_p2sb_enable_bar into bootblock_ioe_early_init
4. move fast_spi_cache_bios_region into bootblock_soc_early_init
5. move pch_early_iorange_init into bootblock_soc_early_init
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62772
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I26479fcc3a3f9c6f8ebf5f198ab0809f0b4a2cc4
Gerrit-Change-Number: 62772
Gerrit-PatchSet: 10
Gerrit-Owner: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Ethan Tsao
ethan.tsao@intel.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Ethan Tsao
ethan.tsao@intel.corp-partner.google.com
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Ravishankar Sarawadi
ravishankar.sarawadi@intel.corp-partner.google.com
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Attention: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Attention: Ethan Tsao
ethan.tsao@intel.com
Gerrit-Attention: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Raj Astekar
raj.astekar@intel.com
Gerrit-Attention: Ravishankar Sarawadi
ravishankar.sarawadi@intel.corp-partner.google.com
Gerrit-Comment-Date: Mon, 02 May 2022 23:28:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment