Philip Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/56354 )
Change subject: mb/google/herobrine: Retrieve SKU ID from EC ......................................................................
mb/google/herobrine: Retrieve SKU ID from EC
BUG=b:186264627 BRANCH=none TEST=build herobrine
Signed-off-by: Philip Chen philipchen@google.com Change-Id: Id3faf7af64c0129ec646a01085adc43b561225d2 --- M src/mainboard/google/herobrine/Kconfig M src/mainboard/google/herobrine/boardid.c 2 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/56354/1
diff --git a/src/mainboard/google/herobrine/Kconfig b/src/mainboard/google/herobrine/Kconfig index 7f88b94..38bb328 100644 --- a/src/mainboard/google/herobrine/Kconfig +++ b/src/mainboard/google/herobrine/Kconfig @@ -9,6 +9,7 @@ select COMMON_CBFS_SPI_WRAPPER select EC_GOOGLE_CHROMEEC if !BOARD_GOOGLE_SENOR select EC_GOOGLE_CHROMEEC_RTC if !BOARD_GOOGLE_SENOR + select EC_GOOGLE_CHROMEEC_SKUID if !BOARD_GOOGLE_SENOR select EC_GOOGLE_CHROMEEC_SPI if !BOARD_GOOGLE_SENOR select RTC if !BOARD_GOOGLE_SENOR select MISSING_BOARD_RESET if BOARD_GOOGLE_SENOR diff --git a/src/mainboard/google/herobrine/boardid.c b/src/mainboard/google/herobrine/boardid.c index eecbeab..6368d25 100644 --- a/src/mainboard/google/herobrine/boardid.c +++ b/src/mainboard/google/herobrine/boardid.c @@ -1,6 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <boardid.h> +#include <ec/google/chromeec/ec.h> #include <gpio.h>
uint32_t board_id(void) @@ -19,7 +20,5 @@
uint32_t sku_id(void) { - static uint32_t id = UNDEFINED_STRAPPING_ID; - - return id; + return google_chromeec_get_board_sku(); }