Attention is currently required from: Hung-Te Lin, Philipp Hug, Matt DeVillier, Julius Werner, Angel Pons, Andrey Petrov, ron minnich, Elyes Haouas, Felix Held.
Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69078 )
Change subject: cbmem_top_chipset: Change the return value to uintptr_t
......................................................................
Patch Set 1:
(3 comments)
File src/northbridge/intel/i440bx/memmap.c:
https://review.coreboot.org/c/coreboot/+/69078/comment/5c6fe0c9_a1ddc7fd
PS1, Line 48: int tseg_size = 128 * KiB * (1 << (tseg >> 1));
: tom -= tseg_size;
Shouldn't this be changed too? What's the purpose of integer type here? (And above too)
File src/northbridge/intel/x4x/memmap.c:
https://review.coreboot.org/c/coreboot/+/69078/comment/65e9f290_ad319f7c
PS1, Line 76: uintptr_t top_of_ram = ALIGN_DOWN(northbridge_get_tseg_base(), 4*MiB);
: return top_of_ram;
Can it fit in one line?
File src/soc/sifive/fu540/cbmem.c:
https://review.coreboot.org/c/coreboot/+/69078/comment/dd336fd3_2b8c3d2f
PS1, Line 11: return MIN((uintptr_t)_dram + sdram_size_mb() * MiB,
: FU540_MAXDRAM);
nit: Can it fit in one line?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69078
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I93645ef5dd270905ce421e68e342aff4c331eae6
Gerrit-Change-Number: 69078
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Philipp Hug
philipp@hug.cx
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: ron minnich
rminnich@gmail.com
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 02 Nov 2022 11:46:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment