Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Felix Held. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56227 )
Change subject: soc/amd/cezanne: Move APOB update into ramstage ......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56227/comment/fd6741bf_623a5d6d PS2, Line 10: it into ramstage allow us to use threads to pre-load the apob from SPI. Does it offer boot time savings? If so, can you please capture in the commit message regarding how much savings is observed?
https://review.coreboot.org/c/coreboot/+/56227/comment/ebb0bba9_8c01b184 PS2, Line 13: and picasso Nit: Zork and Guybrush?
File src/soc/amd/common/block/apob/apob_cache.c:
https://review.coreboot.org/c/coreboot/+/56227/comment/cc5005f5_c6b39b13 PS2, Line 187: OOT_STATE_INIT_ENTRY(BS_POST_DEVICE, BS_ON_EXIT, soc_update_apob_cache, NULL); If there is a reason why not before this boot state and why not after this boot state, can you please mention that in the comment. That will ensure no one plays with this callback.
-
Karthik Ramasubramanian (Code Review)