Peter Lemenkov has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31115
Change subject: mb/lenovo/z61t/Kconfig: Select I945_LVDS ......................................................................
mb/lenovo/z61t/Kconfig: Select I945_LVDS
This board has almost the same schematics as [xt]60 so this should work.
See also commit 7971582e with Change-Id Iff6dac5a5f61af49456bc6312e7a376def02ab00.
Change-Id: I8dc9b122eb64b5c1dcd0dbc99ac41aa0f8dd9766 Signed-off-by: Peter Lemenkov lemenkov@gmail.com --- M src/mainboard/lenovo/z61t/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/31115/1
diff --git a/src/mainboard/lenovo/z61t/Kconfig b/src/mainboard/lenovo/z61t/Kconfig index bfa5c26..9aa6350 100644 --- a/src/mainboard/lenovo/z61t/Kconfig +++ b/src/mainboard/lenovo/z61t/Kconfig @@ -20,9 +20,9 @@ select CHANNEL_XOR_RANDOMIZATION select HAVE_ACPI_TABLES select HAVE_ACPI_RESUME - select MAINBOARD_HAS_NATIVE_VGA_INIT select H8_DOCK_EARLY_INIT select HAVE_CMOS_DEFAULT + select I945_LVDS select INTEL_GMA_HAVE_VBT
config MAINBOARD_DIR
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31115 )
Change subject: mb/lenovo/z61t/Kconfig: Select I945_LVDS ......................................................................
Patch Set 1: Code-Review+1
It should be a no-op
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31115 )
Change subject: mb/lenovo/z61t/Kconfig: Select I945_LVDS ......................................................................
Patch Set 1: Code-Review+2
It should be a no-op
Why? it should allow to select a linear framebuffer, no?
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31115 )
Change subject: mb/lenovo/z61t/Kconfig: Select I945_LVDS ......................................................................
Patch Set 1: Code-Review+2
Patch Set 1: Code-Review+2
It should be a no-op
Why? it should allow to select a linear framebuffer, no?
You are right, I was looking for the first line but completely missed noticing the second line:
select MAINBOARD_HAS_NATIVE_VGA_INIT select HAVE_LINEAR_FRAMEBUFFER if MAINBOARD_DO_NATIVE_VGA_INIT
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31115 )
Change subject: mb/lenovo/z61t/Kconfig: Select I945_LVDS ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/31115/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31115/1//COMMIT_MSG@11 PS1, Line 11: commit 7971582e Please add the commit message summary in parentheses.
commit 7971582e (Kconfig: Introduce HAVE_(VBE_)LINEAR_FRAMEBUFFER)
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31115 )
Change subject: mb/lenovo/z61t/Kconfig: Select I945_LVDS ......................................................................
mb/lenovo/z61t/Kconfig: Select I945_LVDS
This board has almost the same schematics as [xt]60 so this should work.
See also commit 7971582e with Change-Id Iff6dac5a5f61af49456bc6312e7a376def02ab00.
Change-Id: I8dc9b122eb64b5c1dcd0dbc99ac41aa0f8dd9766 Signed-off-by: Peter Lemenkov lemenkov@gmail.com Reviewed-on: https://review.coreboot.org/c/31115 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/lenovo/z61t/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/lenovo/z61t/Kconfig b/src/mainboard/lenovo/z61t/Kconfig index bfa5c26..9aa6350 100644 --- a/src/mainboard/lenovo/z61t/Kconfig +++ b/src/mainboard/lenovo/z61t/Kconfig @@ -20,9 +20,9 @@ select CHANNEL_XOR_RANDOMIZATION select HAVE_ACPI_TABLES select HAVE_ACPI_RESUME - select MAINBOARD_HAS_NATIVE_VGA_INIT select H8_DOCK_EARLY_INIT select HAVE_CMOS_DEFAULT + select I945_LVDS select INTEL_GMA_HAVE_VBT
config MAINBOARD_DIR
-
Angel Pons (Code Review) -
Nico Huber (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)
-
Peter Lemenkov (Code Review)