Change in coreboot[master]: ish: enable for Sarien - coreboot-gerrit

6 Nov 2018


      Jonathan Neuschäfer has posted comments on this change. ( https://review.coreboot.org/29493 )
Change subject: ish: enable for Sarien
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/29493/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/29493/1//COMMIT_MSG@7
PS1, Line 7: ish: enable for Sarien
"ish" is not a good prefix, because there is no "ish" directory anywhere. A better commit message would perhaps be "mb/google/sarien: Enable ISH"
(I think it would also be useful to spell out what ISH means. It is not obvious for casual reviewers like me)
-- 
To view, visit https://review.coreboot.org/29493
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdb9eae3bb5e8beef3b6727ef8aae88d16893666
Gerrit-Change-Number: 29493
Gerrit-PatchSet: 1
Gerrit-Owner: Li1 Feng li1.feng@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Jonathan Neuschäfer j.neuschaefer@gmx.net
Gerrit-Comment-Date: Tue, 06 Nov 2018 11:05:19 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No