[M] Change in coreboot[master]: drivers/intel/dtbt: Add discrete Thunderbolt driver

[Tim Crawford (Code Review)]

Attention is currently required from: Kyösti Mälkki, Martin L Roth, Michał Żygowski, Paul Menzel, Tim Wawrzynczak.

Tim Crawford has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75286?usp=email )

Change subject: drivers/intel/dtbt: Add discrete Thunderbolt driver
......................................................................

Patch Set 8:

(3 comments)

File src/drivers/intel/dtbt/dtbt.c:

https://review.coreboot.org/c/coreboot/+/75286/comment/6343c80b_10fa7f46 :
PS6, Line 83: 		{
> Does this type of indentation to mimic ASL blocks appear somewhere else in our tree already? I under […]

It's used in a couple of places, but yes it's a waste. I've moved some of the logic to helper functions, so hopefully it's simple enough to read straight through without the indentation.

https://review.coreboot.org/c/coreboot/+/75286/comment/98a6f818_c9b216a6 :
PS6, Line 88: 			const struct opregion opregion = OPREGION("PXCS", SYSTEMMEMORY, mmconf_base, 0x1000);
> I thought we are at linewidth 96 except for printk() strings. […]

Done

https://review.coreboot.org/c/coreboot/+/75286/comment/a2e8435f_ec81984a :
PS6, Line 105: 				acpigen_write_delay_until_namestr_int(600, "TB2P", PCIE2TBT_GO2SX_NO_WAKE);
> As you decided to remove shift from PCIE2TBT_GO2SX_NO_WAKE define, you need to add it here now.

Done