Change in coreboot[master]: src/soc/amd: Remove direct 'include <soc/gpio.h>'

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41327 )

Change subject: src/soc/amd: Remove direct 'include <soc/gpio.h>'
......................................................................

src/soc/amd: Remove direct 'include <soc/gpio.h>'

Don't directly include <soc/gpio.h>. All code using GPIO features
should always and only include <gpio.h>, which should indirectly
include the SoC-specific <soc/gpio.h>.

Change-Id: Ibe93386c1e48a8fe4083563eac5e7c62b64f4eab
Signed-off-by: Elyes HAOUAS 
---
M src/soc/amd/common/block/gpio_banks/gpio.c
M src/soc/amd/picasso/acpi.c
M src/soc/amd/picasso/gpio.c
M src/soc/amd/picasso/uart.c
M src/soc/amd/stoneyridge/acpi.c
M src/soc/amd/stoneyridge/gpio.c
6 files changed, 5 insertions(+), 6 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/41327/1

diff --git a/src/soc/amd/common/block/gpio_banks/gpio.c b/src/soc/amd/common/block/gpio_banks/gpio.c
index 2d4558f..d895c4a 100644
--- a/src/soc/amd/common/block/gpio_banks/gpio.c
+++ b/src/soc/amd/common/block/gpio_banks/gpio.c
@@ -6,7 +6,6 @@
 #include <gpio.h>
 #include <amdblocks/acpimmio.h>
 #include <amdblocks/acpimmio_map.h>
-#include <soc/gpio.h>
 #include <soc/smi.h>
 #include <assert.h>

diff --git a/src/soc/amd/picasso/acpi.c b/src/soc/amd/picasso/acpi.c
index a02d8f3..c0c11de 100644
--- a/src/soc/amd/picasso/acpi.c
+++ b/src/soc/amd/picasso/acpi.c
@@ -22,7 +22,7 @@
 #include <soc/southbridge.h>
 #include <soc/northbridge.h>
 #include <soc/nvs.h>
-#include <soc/gpio.h>
+#include <gpio.h>
 #include <version.h>

unsigned long acpi_fill_madt(unsigned long current)
diff --git a/src/soc/amd/picasso/gpio.c b/src/soc/amd/picasso/gpio.c
index c402fb5..f6e6cca 100644
--- a/src/soc/amd/picasso/gpio.c
+++ b/src/soc/amd/picasso/gpio.c
@@ -3,7 +3,7 @@
 #include <stdint.h>
 #include <amdblocks/gpio_banks.h>
 #include <amdblocks/acpimmio.h>
-#include <soc/gpio.h>
+#include <gpio.h>
 #include <soc/smi.h>

static const struct soc_amd_event gpio_event_table[] = {
diff --git a/src/soc/amd/picasso/uart.c b/src/soc/amd/picasso/uart.c
index 6ae79b95..334b567 100644
--- a/src/soc/amd/picasso/uart.c
+++ b/src/soc/amd/picasso/uart.c
@@ -6,7 +6,7 @@
 #include <amdblocks/gpio_banks.h>
 #include <amdblocks/acpimmio.h>
 #include <soc/southbridge.h>
-#include <soc/gpio.h>
+#include <gpio.h>

static const struct _uart_info {
    uintptr_t base;
diff --git a/src/soc/amd/stoneyridge/acpi.c b/src/soc/amd/stoneyridge/acpi.c
index c98a1b4..a1600b5 100644
--- a/src/soc/amd/stoneyridge/acpi.c
+++ b/src/soc/amd/stoneyridge/acpi.c
@@ -21,7 +21,7 @@
 #include <soc/southbridge.h>
 #include <soc/northbridge.h>
 #include <soc/nvs.h>
-#include <soc/gpio.h>
+#include <gpio.h>
 #include <version.h>

unsigned long acpi_fill_madt(unsigned long current)
diff --git a/src/soc/amd/stoneyridge/gpio.c b/src/soc/amd/stoneyridge/gpio.c
index a595014..106b762 100644
--- a/src/soc/amd/stoneyridge/gpio.c
+++ b/src/soc/amd/stoneyridge/gpio.c
@@ -3,7 +3,7 @@
 #include <stdint.h>
 #include <amdblocks/gpio_banks.h>
 #include <amdblocks/acpimmio.h>
-#include <soc/gpio.h>
+#include <gpio.h>
 #include <soc/smi.h>

static const struct soc_amd_event gpio_event_table[] = {

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/41327 )

Change subject: src/soc/amd: Remove direct 'include <soc/gpio.h>'
......................................................................

Abandoned

see #41324