Change in ...coreboot[master]: {drivers,mb,soc/intel/braswell}: Add support for Braswell FSP MR2
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29661 )
Change subject: {drivers,mb,soc/intel/braswell}: Add support for Braswell FSP MR2 ......................................................................
Patch Set 9:
(2 comments)
I like the solution with the move of UPDs to the mainboards. But that still leaves the settings in the soc's chip.h, right?
https://review.coreboot.org/#/c/29661/9//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/29661/9//COMMIT_MSG@16 PS9, Line 16: "../../../3rdparty/fsp/BraswellFspBinPkg" I've been looking through the patch and couldn't find this. I guess, now, you meant to say that this needs to be set per mainboard?
IMHO, 3rdparty/fsp/ should be the default, and main- boards that require the lost FSP version, should override it to vendorcode/intel/...
Maybe we can reduce the noise of these mainboards by removing intel/strago from the tree? Does anybody care about it?
https://review.coreboot.org/#/c/29661/9/src/drivers/intel/fsp1_1/Makefile.in... File src/drivers/intel/fsp1_1/Makefile.inc:
https://review.coreboot.org/#/c/29661/9/src/drivers/intel/fsp1_1/Makefile.in... PS9, Line 61: endif This seems redundant with the change to braswell/Makefile.inc and the existing in vendorcode/intel/?
-
Nico Huber (Code Review)