Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31665
Change subject: cpu/intel/model_1067x: Don't try to apply MCU a second time ......................................................................
cpu/intel/model_1067x: Don't try to apply MCU a second time
Applying microcode updates a second time seems to be only necessary on newer platforms (Nehalem+) for "uncore" updates.
Change-Id: Ia2ee9c70677190ffd1a08df1101d39a14fc2c384 Signed-off-by: Nico Huber nico.h@gmx.de --- M src/cpu/intel/model_1067x/mp_init.c 1 file changed, 0 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/31665/1
diff --git a/src/cpu/intel/model_1067x/mp_init.c b/src/cpu/intel/model_1067x/mp_init.c index b8b3159..4b67893 100644 --- a/src/cpu/intel/model_1067x/mp_init.c +++ b/src/cpu/intel/model_1067x/mp_init.c @@ -85,9 +85,6 @@
/* Relocate the SMM handler. */ smm_relocate(); - - /* After SMM relocation a 2nd microcode load is required. */ - intel_microcode_load_unlocked(microcode_patch); }
static void post_mp_init(void)
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31665 )
Change subject: cpu/intel/model_1067x: Don't try to apply MCU a second time ......................................................................
Patch Set 1: Code-Review+2
Masanori Ogino has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31665 )
Change subject: cpu/intel/model_1067x: Don't try to apply MCU a second time ......................................................................
Patch Set 1: Code-Review+1
Tested this change on top of https://review.coreboot.org/c/coreboot/+/31664 on X60s (Core Solo U1300) with SeaBIOS, Linux 4.19.0 booted successfully and microcode was loaded. Note that U1300 is a single-core processor without HTT.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31665 )
Change subject: cpu/intel/model_1067x: Don't try to apply MCU a second time ......................................................................
Patch Set 1: Code-Review+2