Attention is currently required from: Arthur Heymans, Kyösti Mälkki, Michał Żygowski.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76278?usp=email )
Change subject: nb/pi/00730F01: Rework nb resource reading
......................................................................
Patch Set 3:
(1 comment)
File src/northbridge/amd/pi/00730F01/northbridge.c:
https://review.coreboot.org/c/coreboot/+/76278/comment/9113c662_d43c20d1 :
PS3, Line 103: so shift left by 8 bits
: * for physical address and the convert to KiB by shifting 10 bits left
this comment should be updated to match the new code
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76278?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5685de63ff8971fc4873080e4b9542e6bbf58509
Gerrit-Change-Number: 76278
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Fri, 04 Aug 2023 15:10:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment