[M] Change in coreboot[master]: soc/intel/cse_lite: Back up PSR data during CSE FW downgrade
Attention is currently required from: Subrata Banik, Paul Menzel, Sridhar Siricilla.
Anil Kumar K has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74577 )
Change subject: soc/intel/cse_lite: Back up PSR data during CSE FW downgrade ......................................................................
Patch Set 30:
(6 comments)
File src/soc/intel/common/block/cse/cse_lite.c:
https://review.coreboot.org/c/coreboot/+/74577/comment/e3318415_b2d25398 PS27, Line 156: 0x4
updated new patchset . […]
Done
File src/soc/intel/common/block/cse/cse_lite.c:
https://review.coreboot.org/c/coreboot/+/74577/comment/7cdd9fe5_cee06d89 PS30, Line 157: backup PSR command erro
nit: PSR_HECI_FW_DOWNGRADE_BKUP command send failure?
Ack
https://review.coreboot.org/c/coreboot/+/74577/comment/deb06da3_f27645f2 PS30, Line 776: if (cse_boot_to_rw(cse_bp_info) == CB_SUCCESS) {
Please add a comment like this command requires CSE must boot from RW partition. […]
Ack
https://review.coreboot.org/c/coreboot/+/74577/comment/199f6704_35a6fa8c PS30, Line 781: return;
This is command send failure case, what is the error recovery path here? Do you want to consider tri […]
if command failed we plan to log this as a elog event. There is no need to go to recovery as this is not a catastrophic event . I will push a seperate patch to define new elog event for this purpose. This is WIP
https://review.coreboot.org/c/coreboot/+/74577/comment/fde6cdce_1d2c574b PS30, Line 784: Log
Update?
Ack
https://review.coreboot.org/c/coreboot/+/74577/comment/c2d881fb_94d839da PS30, Line 786: cmos_write(PSR_BACKUP_DONE, PSR_BACKUP_STATUS_CMOS_OFFSET);
It is better we log an event in the event log.
we are planning to log failure events in elog as mentioned above
-
Anil Kumar K (Code Review)