Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/51946 )
Change subject: mb/purism/librem_14: acpi: Remove unused EC define ......................................................................
mb/purism/librem_14: acpi: Remove unused EC define
The define for color keyboard setting has never been used, as it was added as a Kconfig selection when ec/system76/ec was introduced.
Change-Id: Iec9134e226382d32783342ef1d37c6f6f6caeb6e Signed-off-by: Tim Crawford tcrawford@system76.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/51946 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Matt DeVillier matt.devillier@gmail.com --- M src/mainboard/purism/librem_cnl/variants/librem_14/include/variant/acpi/variant.asl 1 file changed, 0 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Matt DeVillier: Looks good to me, approved
diff --git a/src/mainboard/purism/librem_cnl/variants/librem_14/include/variant/acpi/variant.asl b/src/mainboard/purism/librem_cnl/variants/librem_14/include/variant/acpi/variant.asl index def6ee0..7f0326d 100644 --- a/src/mainboard/purism/librem_cnl/variants/librem_14/include/variant/acpi/variant.asl +++ b/src/mainboard/purism/librem_cnl/variants/librem_14/include/variant/acpi/variant.asl @@ -2,7 +2,6 @@
#define EC_GPE_SWI 0x49 /* GPP_E15 */ #define EC_GPE_SCI 0x50 /* GPP_E16 */ -#define EC_COLOR_KEYBOARD 0 #include <ec/system76/ec/acpi/ec.asl>
Scope (_SB) {
-
Patrick Georgi (Code Review)