Change in coreboot[master]: crossgcc: Upgrade cmake to version 3.16.2

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

HAOUAS Elyes (Code Review)

3 Jan 2020 3 Jan '20

1:24 p.m.

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38162 )

Change subject: crossgcc: Upgrade cmake to version 3.16.2 ......................................................................

crossgcc: Upgrade cmake to version 3.16.2

Aslo add comment on IASL conflicting use of _ADR and _HID.

Change-Id: I2012f0adcb348a3ea6c50c361a49a0a600d3db3d Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M util/crossgcc/buildgcc D util/crossgcc/sum/cmake-3.16.0.tar.gz.cksum A util/crossgcc/sum/cmake-3.16.2.tar.gz.cksum 3 files changed, 6 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/38162/1

diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc index 6150011..b862b9a 100755 --- a/util/crossgcc/buildgcc +++ b/util/crossgcc/buildgcc @@ -54,13 +54,17 @@ GCC_AUTOCONF_VERSION=2.69 BINUTILS_VERSION=2.33.1 GDB_VERSION=8.3.1 + +# Conflicting use of _ADR and _HID in coreboot tree needs +# to be properly # addressed before we can upgrade IASL version. +# Use IASL version 20190703 For now. IASL_VERSION=20190703 PYTHON_VERSION=3.8.1 EXPAT_VERSION=2.2.9 # CLANG version number CLANG_VERSION=9.0.0 MAKE_VERSION=4.2.1 -CMAKE_VERSION=3.16.0 +CMAKE_VERSION=3.16.2 NASM_VERSION=2.14.02

# GCC toolchain archive locations diff --git a/util/crossgcc/sum/cmake-3.16.0.tar.gz.cksum b/util/crossgcc/sum/cmake-3.16.0.tar.gz.cksum deleted file mode 100644 index 0adcc1a..0000000 --- a/util/crossgcc/sum/cmake-3.16.0.tar.gz.cksum +++ /dev/null @@ -1 +0,0 @@ -9943ebbbf076bbe1b54c7dadcd6df28ad0d241ed tarballs/cmake-3.16.0.tar.gz diff --git a/util/crossgcc/sum/cmake-3.16.2.tar.gz.cksum b/util/crossgcc/sum/cmake-3.16.2.tar.gz.cksum new file mode 100644 index 0000000..c5190b2 --- /dev/null +++ b/util/crossgcc/sum/cmake-3.16.2.tar.gz.cksum @@ -0,0 +1 @@ +f514dbd9aa8332a28ba62dd8ce97b0aa0b099491 tarballs/cmake-3.16.2.tar.gz

Attachments:

attachment.htm (text/html — 3.8 KB)

Show replies by date

HAOUAS Elyes (Code Review)

3 Jan 3 Jan

1:25 p.m.

HAOUAS Elyes has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/38162 )

Change subject: crossgcc: Upgrade cmake to version 3.16.2 ......................................................................

crossgcc: Upgrade cmake to version 3.16.2

Aslo add comment on IASL conflicting use of _ADR and _HID.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/38162/2

HAOUAS Elyes (Code Review)

1:30 p.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38162

to look at the new patch set (#3).

Change subject: crossgcc: Upgrade cmake to version 3.16.2 ......................................................................

crossgcc: Upgrade cmake to version 3.16.2

Aslo add comment on IASL conflicting use of _ADR and _HID.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/38162/3

HAOUAS Elyes (Code Review)

1:34 p.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38162

to look at the new patch set (#4).

Change subject: crossgcc: Upgrade cmake to version 3.16.2 ......................................................................

crossgcc: Upgrade cmake to version 3.16.2

Also add comment on IASL conflicting use of _ADR and _HID.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/38162/4

Paul Menzel (Code Review)

2:34 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38162 )

Change subject: crossgcc: Upgrade cmake to version 3.16.2 ......................................................................

Patch Set 4: Code-Review+1

Idwer Vollering (Code Review)

2:45 p.m.

Idwer Vollering has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38162 )

Change subject: crossgcc: Upgrade cmake to version 3.16.2 ......................................................................

Patch Set 4: Code-Review-2

(1 comment)

https://review.coreboot.org/c/coreboot/+/38162/4/util/crossgcc/buildgcc File util/crossgcc/buildgcc:

https://review.coreboot.org/c/coreboot/+/38162/4/util/crossgcc/buildgcc@60 PS4, Line 60: version This change is about cmake, not acpica.

-- To view, visit https://review.coreboot.org/c/coreboot/+/38162 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2012f0adcb348a3ea6c50c361a49a0a600d3db3d Gerrit-Change-Number: 38162 Gerrit-PatchSet: 4 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 03 Jan 2020 13:45:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

4:04 p.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38162 )

Change subject: crossgcc: Upgrade cmake to version 3.16.2 ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38162/4/util/crossgcc/buildgcc File util/crossgcc/buildgcc:

https://review.coreboot.org/c/coreboot/+/38162/4/util/crossgcc/buildgcc@60 PS4, Line 60: version

...

This change is about cmake, not acpica.

Thank you. yes you are right. I'll split it to 2 parts.

-- To view, visit https://review.coreboot.org/c/coreboot/+/38162 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2012f0adcb348a3ea6c50c361a49a0a600d3db3d Gerrit-Change-Number: 38162 Gerrit-PatchSet: 4 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 03 Jan 2020 15:04:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Idwer Vollering vidwer@gmail.com Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

4:10 p.m.

Hello Idwer Vollering, Paul Menzel, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38162

to look at the new patch set (#5).

Change subject: crossgcc: Upgrade cmake to version 3.16.2 ......................................................................

crossgcc: Upgrade cmake to version 3.16.2

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/38162/5

Idwer Vollering (Code Review)

5:43 p.m.

Idwer Vollering has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38162 )

Change subject: crossgcc: Upgrade cmake to version 3.16.2 ......................................................................

Patch Set 5: -Code-Review

-- To view, visit https://review.coreboot.org/c/coreboot/+/38162 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2012f0adcb348a3ea6c50c361a49a0a600d3db3d Gerrit-Change-Number: 38162 Gerrit-PatchSet: 5 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 03 Jan 2020 16:43:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Stefan Reinauer (Code Review)

11 Jan 11 Jan

1:17 a.m.

Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38162 )

Change subject: crossgcc: Upgrade cmake to version 3.16.2 ......................................................................

Patch Set 5: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/38162 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2012f0adcb348a3ea6c50c361a49a0a600d3db3d Gerrit-Change-Number: 38162 Gerrit-PatchSet: 5 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sat, 11 Jan 2020 00:17:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

14 Jan 14 Jan

6:59 p.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38162 )

Change subject: crossgcc: Upgrade cmake to version 3.16.2 ......................................................................

crossgcc: Upgrade cmake to version 3.16.2

Change-Id: I2012f0adcb348a3ea6c50c361a49a0a600d3db3d Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/38162 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Stefan Reinauer stefan.reinauer@coreboot.org --- M util/crossgcc/buildgcc D util/crossgcc/sum/cmake-3.16.0.tar.gz.cksum A util/crossgcc/sum/cmake-3.16.2.tar.gz.cksum 3 files changed, 2 insertions(+), 2 deletions(-)

Approvals: build bot (Jenkins): Verified Stefan Reinauer: Looks good to me, approved

diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc index b3b92d4..ab2ea89 100755 --- a/util/crossgcc/buildgcc +++ b/util/crossgcc/buildgcc @@ -64,7 +64,7 @@ # CLANG version number CLANG_VERSION=9.0.0 MAKE_VERSION=4.2.1 -CMAKE_VERSION=3.16.0 +CMAKE_VERSION=3.16.2 NASM_VERSION=2.14.02

-- To view, visit https://review.coreboot.org/c/coreboot/+/38162 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2012f0adcb348a3ea6c50c361a49a0a600d3db3d Gerrit-Change-Number: 38162 Gerrit-PatchSet: 6 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

9elements QA (Code Review)

7:13 p.m.

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38162 )

Change subject: crossgcc: Upgrade cmake to version 3.16.2 ......................................................................

Patch Set 6:

Automatic boot test returned (PASS/FAIL/TOTAL): 3/0/3 Emulation targets: EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : No test failed. EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : No test failed. EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : No test failed.

Please note: This test is under development and might not be accurate at all!

-- To view, visit https://review.coreboot.org/c/coreboot/+/38162 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2012f0adcb348a3ea6c50c361a49a0a600d3db3d Gerrit-Change-Number: 38162 Gerrit-PatchSet: 6 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com Gerrit-Comment-Date: Tue, 14 Jan 2020 18:13:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1577

days inactive

1588

days old

coreboot-gerrit@coreboot.org

11 comments

6 participants

tags (0)

participants (6)

9elements QA (Code Review)
HAOUAS Elyes (Code Review)
Idwer Vollering (Code Review)
Patrick Georgi (Code Review)
Paul Menzel (Code Review)
Stefan Reinauer (Code Review)