Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38297 )
Change subject: intel/nehalem,ibexpeak: Move enable_smbus() call ......................................................................
intel/nehalem,ibexpeak: Move enable_smbus() call
Change-Id: I6e43f7696b289ce9e0319afdcc73889ddabd4db1 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/northbridge/intel/nehalem/romstage.c M src/southbridge/intel/ibexpeak/early_pch.c 2 files changed, 1 insertion(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/38297/1
diff --git a/src/northbridge/intel/nehalem/romstage.c b/src/northbridge/intel/nehalem/romstage.c index 69383e6..eceb8c2 100644 --- a/src/northbridge/intel/nehalem/romstage.c +++ b/src/northbridge/intel/nehalem/romstage.c @@ -57,9 +57,6 @@ } }
- /* Enable SMBUS. */ - enable_smbus(); - early_thermal_init();
timestamp_add_now(TS_BEFORE_INITRAM); diff --git a/src/southbridge/intel/ibexpeak/early_pch.c b/src/southbridge/intel/ibexpeak/early_pch.c index b76115b..e462dd8 100644 --- a/src/southbridge/intel/ibexpeak/early_pch.c +++ b/src/southbridge/intel/ibexpeak/early_pch.c @@ -44,6 +44,7 @@ void early_pch_init(void) { early_gpio_init(); + enable_smbus(); /* TODO, make this configurable */ pch_setup_cir(NEHALEM_MOBILE); southbridge_configure_default_intmap();
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38297 )
Change subject: intel/nehalem,ibexpeak: Move enable_smbus() call ......................................................................
Patch Set 1: Code-Review+2
Hello Patrick Rudolph, Arthur Heymans, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38297
to look at the new patch set (#2).
Change subject: intel/nehalem,ibexpeak: Move enable_smbus() call ......................................................................
intel/nehalem,ibexpeak: Move enable_smbus() call
Change-Id: I6e43f7696b289ce9e0319afdcc73889ddabd4db1 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/northbridge/intel/nehalem/romstage.c M src/southbridge/intel/ibexpeak/early_pch.c 2 files changed, 1 insertion(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/38297/2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38297 )
Change subject: intel/nehalem,ibexpeak: Move enable_smbus() call ......................................................................
Patch Set 3: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38297 )
Change subject: intel/nehalem,ibexpeak: Move enable_smbus() call ......................................................................
intel/nehalem,ibexpeak: Move enable_smbus() call
Change-Id: I6e43f7696b289ce9e0319afdcc73889ddabd4db1 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/38297 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Arthur Heymans arthur@aheymans.xyz --- M src/northbridge/intel/nehalem/romstage.c M src/southbridge/intel/ibexpeak/early_pch.c 2 files changed, 1 insertion(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/northbridge/intel/nehalem/romstage.c b/src/northbridge/intel/nehalem/romstage.c index 69383e6..eceb8c2 100644 --- a/src/northbridge/intel/nehalem/romstage.c +++ b/src/northbridge/intel/nehalem/romstage.c @@ -57,9 +57,6 @@ } }
- /* Enable SMBUS. */ - enable_smbus(); - early_thermal_init();
timestamp_add_now(TS_BEFORE_INITRAM); diff --git a/src/southbridge/intel/ibexpeak/early_pch.c b/src/southbridge/intel/ibexpeak/early_pch.c index b76115b..e462dd8 100644 --- a/src/southbridge/intel/ibexpeak/early_pch.c +++ b/src/southbridge/intel/ibexpeak/early_pch.c @@ -44,6 +44,7 @@ void early_pch_init(void) { early_gpio_init(); + enable_smbus(); /* TODO, make this configurable */ pch_setup_cir(NEHALEM_MOBILE); southbridge_configure_default_intmap();