Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40120 )
Change subject: mb/google/cyan: Use ACPI backlight contrls ......................................................................
mb/google/cyan: Use ACPI backlight contrls
Enables ACPI backlight controls under Windows.
Test: boot Win 10 on cyan and edgar variants, verify screen backlight controls available and functional.
Change-Id: I8976291b5bafaec934d0bfd91fcdab50b381beec Signed-off-by: Matt DeVillier matt.devillier@gmail.com --- M src/mainboard/google/cyan/devicetree.cb M src/mainboard/google/cyan/dsdt.asl 2 files changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/40120/1
diff --git a/src/mainboard/google/cyan/devicetree.cb b/src/mainboard/google/cyan/devicetree.cb index b13f3f9..91e9795 100644 --- a/src/mainboard/google/cyan/devicetree.cb +++ b/src/mainboard/google/cyan/devicetree.cb @@ -1,5 +1,8 @@ chip soc/intel/braswell
+ # IGD Displays + register "gfx" = "GMA_STATIC_DISPLAYS(0)" + ############################################################ # Set the parameters for MemoryInit ############################################################ diff --git a/src/mainboard/google/cyan/dsdt.asl b/src/mainboard/google/cyan/dsdt.asl index 90dfa37..f9f4940 100644 --- a/src/mainboard/google/cyan/dsdt.asl +++ b/src/mainboard/google/cyan/dsdt.asl @@ -33,6 +33,7 @@ Device (PCI0) { #include <acpi/southcluster.asl> + #include <drivers/intel/gma/acpi/default_brightness_levels.asl> #if CONFIG(BOARD_GOOGLE_TERRA) #include <variant/acpi/cpu.asl> #else
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40120 )
Change subject: mb/google/cyan: Use ACPI backlight contrls ......................................................................
Patch Set 1: Code-Review+2
Matt DeVillier has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40120 )
Change subject: mb/google/cyan: Use ACPI backlight contrls ......................................................................
mb/google/cyan: Use ACPI backlight contrls
Enables ACPI backlight controls under Windows.
Test: boot Win 10 on cyan and edgar variants, verify screen backlight controls available and functional.
Change-Id: I8976291b5bafaec934d0bfd91fcdab50b381beec Signed-off-by: Matt DeVillier matt.devillier@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/40120 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/google/cyan/devicetree.cb M src/mainboard/google/cyan/dsdt.asl 2 files changed, 4 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/google/cyan/devicetree.cb b/src/mainboard/google/cyan/devicetree.cb index b13f3f9..91e9795 100644 --- a/src/mainboard/google/cyan/devicetree.cb +++ b/src/mainboard/google/cyan/devicetree.cb @@ -1,5 +1,8 @@ chip soc/intel/braswell
+ # IGD Displays + register "gfx" = "GMA_STATIC_DISPLAYS(0)" + ############################################################ # Set the parameters for MemoryInit ############################################################ diff --git a/src/mainboard/google/cyan/dsdt.asl b/src/mainboard/google/cyan/dsdt.asl index 90dfa37..f9f4940 100644 --- a/src/mainboard/google/cyan/dsdt.asl +++ b/src/mainboard/google/cyan/dsdt.asl @@ -33,6 +33,7 @@ Device (PCI0) { #include <acpi/southcluster.asl> + #include <drivers/intel/gma/acpi/default_brightness_levels.asl> #if CONFIG(BOARD_GOOGLE_TERRA) #include <variant/acpi/cpu.asl> #else
-
Angel Pons (Code Review) -
Matt DeVillier (Code Review)