Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45107 )
Change subject: mb/system76/lemp9: Move SATA options into devicetree ......................................................................
mb/system76/lemp9: Move SATA options into devicetree
Change-Id: Idf64d98b36ca95a8bc17a6544993c26e23851cd8 Signed-off-by: Felix Singer felixsinger@posteo.net --- M src/mainboard/system76/lemp9/devicetree.cb 1 file changed, 6 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/45107/1
diff --git a/src/mainboard/system76/lemp9/devicetree.cb b/src/mainboard/system76/lemp9/devicetree.cb index 2e17a81..8576ee2 100644 --- a/src/mainboard/system76/lemp9/devicetree.cb +++ b/src/mainboard/system76/lemp9/devicetree.cb @@ -35,13 +35,6 @@ #register "enable_c6dram" = "1"
# FSP Silicon (soc/intel/cannonlake/fsp_params.c) - # SATA - register "SataMode" = "Sata_AHCI" - register "SataSalpSupport" = "0" - - register "SataPortsEnable[1]" = "1" - register "SataPortsEnable[2]" = "1" - # Audio register "PchHdaDspEnable" = "0" register "PchHdaAudioLinkHda" = "1" @@ -172,7 +165,12 @@ register "Heci3Enabled" = "0" end device pci 16.5 off end # Management Engine Interface 4 - device pci 17.0 on end # SATA + device pci 17.0 on # SATA + register "SataMode" = "Sata_AHCI" + register "SataSalpSupport" = "0" + register "SataPortsEnable[1]" = "1" + register "SataPortsEnable[2]" = "1" + end device pci 19.0 off end # I2C #4 device pci 19.1 off end # I2C #5 device pci 19.2 on end # UART #2
Hello Jeremy Soller, Michael Niewöhner,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45107
to look at the new patch set (#2).
Change subject: mb/system76/lemp9: Move SATA options into devicetree ......................................................................
mb/system76/lemp9: Move SATA options into devicetree
Change-Id: Idf64d98b36ca95a8bc17a6544993c26e23851cd8 Signed-off-by: Felix Singer felixsinger@posteo.net --- M src/mainboard/system76/lemp9/devicetree.cb 1 file changed, 6 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/45107/2
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45107 )
Change subject: mb/system76/lemp9: Move SATA options into devicetree ......................................................................
Patch Set 2: Code-Review+2
Hello build bot (Jenkins), Jeremy Soller, Michael Niewöhner,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45107
to look at the new patch set (#3).
Change subject: mb/system76/lemp9: Move SATA options into devicetree ......................................................................
mb/system76/lemp9: Move SATA options into devicetree
Change-Id: Idf64d98b36ca95a8bc17a6544993c26e23851cd8 Signed-off-by: Felix Singer felixsinger@posteo.net --- M src/mainboard/system76/lemp9/devicetree.cb 1 file changed, 6 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/45107/3
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45107 )
Change subject: mb/system76/lemp9: Move SATA options into devicetree ......................................................................
Patch Set 3: Code-Review+2
Michael Niewöhner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45107 )
Change subject: mb/system76/lemp9: Move SATA options into devicetree ......................................................................
mb/system76/lemp9: Move SATA options into devicetree
Change-Id: Idf64d98b36ca95a8bc17a6544993c26e23851cd8 Signed-off-by: Felix Singer felixsinger@posteo.net Reviewed-on: https://review.coreboot.org/c/coreboot/+/45107 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Michael Niewöhner --- M src/mainboard/system76/lemp9/devicetree.cb 1 file changed, 6 insertions(+), 8 deletions(-)
Approvals: build bot (Jenkins): Verified Michael Niewöhner: Looks good to me, approved
diff --git a/src/mainboard/system76/lemp9/devicetree.cb b/src/mainboard/system76/lemp9/devicetree.cb index dc2a9fe..f0cee06 100644 --- a/src/mainboard/system76/lemp9/devicetree.cb +++ b/src/mainboard/system76/lemp9/devicetree.cb @@ -45,13 +45,6 @@ [PchSerialIoIndexI2C0] = PchSerialIoPci, // Touchpad }"
- # SATA - register "SataMode" = "Sata_AHCI" - register "SataSalpSupport" = "0" - - register "SataPortsEnable[1]" = "1" - register "SataPortsEnable[2]" = "1" - # Audio register "PchHdaDspEnable" = "0" register "PchHdaAudioLinkHda" = "1" @@ -181,7 +174,12 @@ device pci 16.3 off end # Management Engine KT Redirection device pci 16.4 off end # Management Engine Interface 3 device pci 16.5 off end # Management Engine Interface 4 - device pci 17.0 on end # SATA + device pci 17.0 on # SATA + register "SataMode" = "Sata_AHCI" + register "SataSalpSupport" = "0" + register "SataPortsEnable[1]" = "1" + register "SataPortsEnable[2]" = "1" + end device pci 19.0 off end # I2C #4 device pci 19.1 off end # I2C #5 device pci 19.2 on end # UART #2
-
Felix Singer (Code Review) -
Michael Niewöhner (Code Review)