Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/20979 )
Change subject: nb/intel/x4x/raminit: Move dummy reads after JEDEC init
......................................................................
Patch Set 9:
(1 comment)
https://review.coreboot.org/c/coreboot/+/20979/9/src/northbridge/intel/x4x/r...
File src/northbridge/intel/x4x/raminit_ddr23.c:
https://review.coreboot.org/c/coreboot/+/20979/9/src/northbridge/intel/x4x/r...
PS9, Line 2163: test_address(ch, r) | 0x800000 | (bank << 12)
probably some parenthesis are missing around this statement, so that not only the first element gets type casted, but the whole expression
--
To view, visit
https://review.coreboot.org/c/coreboot/+/20979
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8069f9c08ad5e5268ddbe3711d58bc42522f938c
Gerrit-Change-Number: 20979
Gerrit-PatchSet: 9
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 02 Sep 2019 18:12:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment