Attention is currently required from: Ravi kumar, Paul Menzel, mturney mturney, Julius Werner, Rajesh Patil.
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50581 )
Change subject: mb/mainboard/herobrine: Initialize SPI FW for EC and TPM
......................................................................
Patch Set 88:
(1 comment)
File src/mainboard/google/herobrine/Kconfig:
https://review.coreboot.org/c/coreboot/+/50581/comment/45eae99b_8de3b424
PS84, Line 66: default 0xC if BOARD_GOOGLE_HEROBRINE
...why wouldn't it? It's true exactly iff you're building for Herobrine (the reference board). […]
Sorry for not being clear. I meant that the Herobrine reference board should be using I2C communication for TPM rather than SPI. Only Hoglin/Piglin are using SPI with TPM.
Agree with the rest of the what Julius said.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50581
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8cbdd1d59a0166688d52d61646db1b6764879a7c
Gerrit-Change-Number: 50581
Gerrit-PatchSet: 88
Gerrit-Owner: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: Mukesh Savaliya
msavaliy@qualcomm.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Rajesh Patil
rajpat@qualcomm.corp-partner.google.com
Gerrit-CC: Ravi Kumar Bokka
c_rbokka@qualcomm.corp-partner.google.com
Gerrit-Attention: Ravi kumar
rbokka@codeaurora.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: mturney mturney
mturney@codeaurora.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Rajesh Patil
rajpat@qualcomm.corp-partner.google.com
Gerrit-Comment-Date: Mon, 15 Nov 2021 21:50:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shelley Chen
shchen@google.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment