EricR Lai has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40745 )
Change subject: mb/google/deltaur: Enable PS/2 keyboard ......................................................................
mb/google/deltaur: Enable PS/2 keyboard
Enable PS/2 keyboard for kernel.
BUG=b:154790509 TEST=Check Keyboard is functional under OS.
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: I31c74ddb3608589e5a4753c7e487f250b112bb1e --- M src/mainboard/google/deltaur/variants/baseboard/include/baseboard/ec.h 1 file changed, 2 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/40745/1
diff --git a/src/mainboard/google/deltaur/variants/baseboard/include/baseboard/ec.h b/src/mainboard/google/deltaur/variants/baseboard/include/baseboard/ec.h index 3825cc8..9f688ae 100644 --- a/src/mainboard/google/deltaur/variants/baseboard/include/baseboard/ec.h +++ b/src/mainboard/google/deltaur/variants/baseboard/include/baseboard/ec.h @@ -7,8 +7,7 @@ #ifndef __MAINBOARD_EC_H__ #define __MAINBOARD_EC_H__
- - - +/* Enable PS/2 keyboard */ +#define SIO_EC_ENABLE_PS2K
#endif /* __MAINBOARD_EC_H__ */
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40745 )
Change subject: mb/google/deltaur: Enable PS/2 keyboard ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/40745/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40745/1//COMMIT_MSG@10 PS1, Line 10: Maybe something like:
By default, the ACPI status method _STA returns false for the PS/2 keyboard and mouse device of the Wilco EC, so the OS does not enable it. Enable these devices, by defining the macro `SIO_EC_ENABLE_PS2K`.
Hello build bot (Jenkins), Paul Menzel,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40745
to look at the new patch set (#2).
Change subject: mb/google/deltaur: Enable PS/2 keyboard ......................................................................
mb/google/deltaur: Enable PS/2 keyboard
By default, the ACPI status method _STA returns false for the PS/2 keyboard and mouse device of the Wilco EC, so the OS does not enable it. Enable these devices, by defining the macro SIO_EC_ENABLE_PS2K.
BUG=b:154790509 TEST=Check Keyboard is functional under OS.
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: I31c74ddb3608589e5a4753c7e487f250b112bb1e --- M src/mainboard/google/deltaur/variants/baseboard/include/baseboard/ec.h 1 file changed, 2 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/40745/2
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40745 )
Change subject: mb/google/deltaur: Enable PS/2 keyboard ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40745/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40745/1//COMMIT_MSG@10 PS1, Line 10:
Maybe something like: […]
Thanks~Paul.
Ivy Jian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40745 )
Change subject: mb/google/deltaur: Enable PS/2 keyboard ......................................................................
Patch Set 2: Code-Review+2
Tim Wawrzynczak has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40745 )
Change subject: mb/google/deltaur: Enable PS/2 keyboard ......................................................................
mb/google/deltaur: Enable PS/2 keyboard
By default, the ACPI status method _STA returns false for the PS/2 keyboard and mouse device of the Wilco EC, so the OS does not enable it. Enable these devices, by defining the macro SIO_EC_ENABLE_PS2K.
BUG=b:154790509 TEST=Check Keyboard is functional under OS.
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: I31c74ddb3608589e5a4753c7e487f250b112bb1e Reviewed-on: https://review.coreboot.org/c/coreboot/+/40745 Reviewed-by: Ivy Jian ivy_jian@compal.corp-partner.google.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/deltaur/variants/baseboard/include/baseboard/ec.h 1 file changed, 2 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Ivy Jian: Looks good to me, approved
diff --git a/src/mainboard/google/deltaur/variants/baseboard/include/baseboard/ec.h b/src/mainboard/google/deltaur/variants/baseboard/include/baseboard/ec.h index 3825cc8..9f688ae 100644 --- a/src/mainboard/google/deltaur/variants/baseboard/include/baseboard/ec.h +++ b/src/mainboard/google/deltaur/variants/baseboard/include/baseboard/ec.h @@ -7,8 +7,7 @@ #ifndef __MAINBOARD_EC_H__ #define __MAINBOARD_EC_H__
- - - +/* Enable PS/2 keyboard */ +#define SIO_EC_ENABLE_PS2K
#endif /* __MAINBOARD_EC_H__ */
-
EricR Lai (Code Review) -
Ivy Jian (Code Review)
-
Paul Menzel (Code Review)
-
Tim Wawrzynczak (Code Review)