Tommie Lin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38823 )
Change subject: mb/google/octopus: support Elan touch panel(include USI pen) for Foob ......................................................................
mb/google/octopus: support Elan touch panel(include USI pen) for Foob
BUG=None TEST=build bios and verify touch screen works fine
Signed-off-by: Tommie Lin tong.lin@bitland.corp-partner.google.com Change-Id: Ibec3d08cc740e398a10a5c845181318724afc70a --- M src/mainboard/google/octopus/variants/foob/overridetree.cb 1 file changed, 11 insertions(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/38823/1
diff --git a/src/mainboard/google/octopus/variants/foob/overridetree.cb b/src/mainboard/google/octopus/variants/foob/overridetree.cb index b131173..fea012b 100644 --- a/src/mainboard/google/octopus/variants/foob/overridetree.cb +++ b/src/mainboard/google/octopus/variants/foob/overridetree.cb @@ -134,16 +134,17 @@ end end # - I2C 6 device pci 17.3 on - chip drivers/i2c/generic - register "hid" = ""ELAN0001"" - register "desc" = ""ELAN Touchscreen"" - register "irq" = "ACPI_IRQ_EDGE_LOW(GPIO_212_IRQ)" - register "probed" = "1" - register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_105)" - register "reset_delay_ms" = "20" - register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_146)" - register "enable_delay_ms" = "1" - register "has_power_resource" = "1" + chip drivers/i2c/hid + register "generic.hid" = ""ELAN0001"" + register "generic.desc" = ""ELAN Touchscreen"" + register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPIO_212_IRQ)" + register "generic.probed" = "1" + register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_105)" + register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_146)" + register "generic.reset_delay_ms" = "20" + register "generic.has_power_resource" = "1" + register "generic.disable_gpio_export_in_crs" = "1" + register "hid_desc_reg_offset" = "0x20" device i2c 10 on end end chip drivers/i2c/hid
Peichao Li has uploaded a new patch set (#2) to the change originally created by Tommie Lin. ( https://review.coreboot.org/c/coreboot/+/38823 )
Change subject: mb/google/octopus: support new Elan touch panel for Foob ......................................................................
mb/google/octopus: support new Elan touch panel for Foob
This is a new elan touch screen IC, which include touch panel and USI pen.
BUG=None TEST=build bios and verify touch screen works fine
Signed-off-by: Tommie Lin tong.lin@bitland.corp-partner.google.com Change-Id: Ibec3d08cc740e398a10a5c845181318724afc70a --- M src/mainboard/google/octopus/variants/foob/overridetree.cb 1 file changed, 11 insertions(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/38823/2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38823 )
Change subject: mb/google/octopus: support new Elan touch panel for Foob ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38823/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38823/2//COMMIT_MSG@9 PS2, Line 9: a new elan touch screen IC Please specify the name, and the datasheet you used.
https://review.coreboot.org/c/coreboot/+/38823/2//COMMIT_MSG@10 PS2, Line 10: and USI pen. Please re-flow for 75 characters per line.
Peichao Li has uploaded a new patch set (#3) to the change originally created by Tommie Lin. ( https://review.coreboot.org/c/coreboot/+/38823 )
Change subject: mb/google/octopus: support new Elan touch panel for Foob ......................................................................
mb/google/octopus: support new Elan touch panel for Foob
This is a new elan touch screen IC, which include touch panel and USI pen.
BUG=b:149800883 TEST=build bios and verify touch screen works fine
Signed-off-by: Tommie Lin tong.lin@bitland.corp-partner.google.com Change-Id: Ibec3d08cc740e398a10a5c845181318724afc70a --- M src/mainboard/google/octopus/variants/foob/overridetree.cb 1 file changed, 11 insertions(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/38823/3
Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38823 )
Change subject: mb/google/octopus: support new Elan touch panel for Foob ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38823/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38823/2//COMMIT_MSG@9 PS2, Line 9: a new elan touch screen IC
Please specify the name, and the datasheet you used.
I have update the ticket: 149800883, control IC is: eKTH6913UAY. the new one, never use it before other project. Thanks a lot!
Hello Peichao Li, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38823
to look at the new patch set (#4).
Change subject: mb/google/octopus: support Elan touch panel(include USI pen) for Foob ......................................................................
mb/google/octopus: support Elan touch panel(include USI pen) for Foob
BUG=None TEST=build bios and verify touch screen works fine
Signed-off-by: Tommie Lin tong.lin@bitland.corp-partner.google.com Change-Id: Ibec3d08cc740e398a10a5c845181318724afc70a --- M src/mainboard/google/octopus/variants/foob/overridetree.cb 1 file changed, 11 insertions(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/38823/4
Hello Peichao Li, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38823
to look at the new patch set (#5).
Change subject: mb/google/octopus: support new Elan touch panel for Foob ......................................................................
mb/google/octopus: support new Elan touch panel for Foob
This is a new elan touch screen IC, which include touch panel and USI pen.
BUG=b:149800883 TEST=build bios and verify touch screen works fine
Signed-off-by: Tommie Lin tong.lin@bitland.corp-partner.google.com Change-Id: Ibec3d08cc740e398a10a5c845181318724afc70a --- M src/mainboard/google/octopus/variants/foob/overridetree.cb 1 file changed, 11 insertions(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/38823/5
Henry Sun has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38823 )
Change subject: mb/google/octopus: support new Elan touch panel for Foob ......................................................................
Patch Set 5: Code-Review+1
Verified by ODM boards
Hello Peichao Li, Henry Sun, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38823
to look at the new patch set (#6).
Change subject: mb/google/octopus: support new Elan touch panel for Foob ......................................................................
mb/google/octopus: support new Elan touch panel for Foob
This is a new elan touch screen IC, which include touch panel and USI pen.
BUG=b:149800883 TEST=build bios and verify touch screen works fine
Signed-off-by: Tommie Lin tong.lin@bitland.corp-partner.google.com Change-Id: Ibec3d08cc740e398a10a5c845181318724afc70a --- M src/mainboard/google/octopus/variants/foob/overridetree.cb 1 file changed, 11 insertions(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/38823/6
Tommie Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38823 )
Change subject: mb/google/octopus: support new Elan touch panel for Foob ......................................................................
Patch Set 6: Code-Review+1
Henry Sun has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38823 )
Change subject: mb/google/octopus: support new Elan touch panel for Foob ......................................................................
Patch Set 6: Code-Review+1
Patchset#6 is to add _HID to the generic.hid string after the vendor code as "ELAN90FC"
Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38823 )
Change subject: mb/google/octopus: support new Elan touch panel for Foob ......................................................................
Patch Set 6: Code-Review+2
Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38823 )
Change subject: mb/google/octopus: support new Elan touch panel for Foob ......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38823/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38823/2//COMMIT_MSG@9 PS2, Line 9: a new elan touch screen IC
I have update the ticket: 149800883, control IC is: eKTH6913UAY. […]
Done
https://review.coreboot.org/c/coreboot/+/38823/2//COMMIT_MSG@10 PS2, Line 10: and USI pen.
Please re-flow for 75 characters per line.
Done
Peichao Li has uploaded a new patch set (#7) to the change originally created by Tommie Lin. ( https://review.coreboot.org/c/coreboot/+/38823 )
Change subject: mb/google/octopus: support new Elan touch panel for Foob ......................................................................
mb/google/octopus: support new Elan touch panel for Foob
This is a new elan touch screen IC, which include touch panel and USI pen.
BUG=b:149800883 TEST=build bios and verify touch screen works fine
Signed-off-by: Tommie Lin tong.lin@bitland.corp-partner.google.com Change-Id: Ibec3d08cc740e398a10a5c845181318724afc70a --- M src/mainboard/google/octopus/variants/foob/overridetree.cb 1 file changed, 11 insertions(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/38823/7
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38823 )
Change subject: mb/google/octopus: support new Elan touch panel for Foob ......................................................................
Patch Set 7:
(3 comments)
Should both screens be supported by the same build?
https://review.coreboot.org/c/coreboot/+/38823/7//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38823/7//COMMIT_MSG@8 PS7, Line 8: for Foob In coreboot we use exactly one line for the commit message summary.
https://review.coreboot.org/c/coreboot/+/38823/7//COMMIT_MSG@10 PS7, Line 10: include includes
https://review.coreboot.org/c/coreboot/+/38823/7//COMMIT_MSG@11 PS7, Line 11: touch panel and USI pen. More words fit in 75 characters lines.
Hello Marco Chen, Peichao Li, Henry Sun, build bot (Jenkins), Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38823
to look at the new patch set (#8).
Change subject: mb/google/octopus: support new Elan touch panel for Foob ......................................................................
mb/google/octopus: support new Elan touch panel for Foob
This is new elan touch screen IC, which includes touch panel and USI pen.
BUG=b:149800883 BRANCH=octopus TEST=build bios and verify touch screen works fine
Signed-off-by: Tommie Lin tong.lin@bitland.corp-partner.google.com Change-Id: Ibec3d08cc740e398a10a5c845181318724afc70a --- M src/mainboard/google/octopus/variants/foob/overridetree.cb 1 file changed, 11 insertions(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/38823/8
Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38823 )
Change subject: mb/google/octopus: support new Elan touch panel for Foob ......................................................................
Patch Set 8:
Patch Set 7:
(3 comments)
Should both screens be supported by the same build?
Dear Paul, maybe yes, since we need according customer requirement to decide, so keep it.
Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38823 )
Change subject: mb/google/octopus: support new Elan touch panel for Foob ......................................................................
Patch Set 8:
(3 comments)
https://review.coreboot.org/c/coreboot/+/38823/7//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38823/7//COMMIT_MSG@8 PS7, Line 8: for Foob
In coreboot we use exactly one line for the commit message summary.
Done
https://review.coreboot.org/c/coreboot/+/38823/7//COMMIT_MSG@10 PS7, Line 10: include
includes
Done
https://review.coreboot.org/c/coreboot/+/38823/7//COMMIT_MSG@11 PS7, Line 11: touch panel and USI pen.
More words fit in 75 characters lines.
Done
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38823 )
Change subject: mb/google/octopus: support new Elan touch panel for Foob ......................................................................
mb/google/octopus: support new Elan touch panel for Foob
This is new elan touch screen IC, which includes touch panel and USI pen.
BUG=b:149800883 BRANCH=octopus TEST=build bios and verify touch screen works fine
Signed-off-by: Tommie Lin tong.lin@bitland.corp-partner.google.com Change-Id: Ibec3d08cc740e398a10a5c845181318724afc70a Reviewed-on: https://review.coreboot.org/c/coreboot/+/38823 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Henry Sun henrysun@google.com Reviewed-by: Marco Chen marcochen@google.com --- M src/mainboard/google/octopus/variants/foob/overridetree.cb 1 file changed, 11 insertions(+), 10 deletions(-)
Approvals: build bot (Jenkins): Verified Marco Chen: Looks good to me, approved Tommie Lin: Looks good to me, but someone else must approve Henry Sun: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/octopus/variants/foob/overridetree.cb b/src/mainboard/google/octopus/variants/foob/overridetree.cb index b131173..004076d 100644 --- a/src/mainboard/google/octopus/variants/foob/overridetree.cb +++ b/src/mainboard/google/octopus/variants/foob/overridetree.cb @@ -134,16 +134,17 @@ end end # - I2C 6 device pci 17.3 on - chip drivers/i2c/generic - register "hid" = ""ELAN0001"" - register "desc" = ""ELAN Touchscreen"" - register "irq" = "ACPI_IRQ_EDGE_LOW(GPIO_212_IRQ)" - register "probed" = "1" - register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_105)" - register "reset_delay_ms" = "20" - register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_146)" - register "enable_delay_ms" = "1" - register "has_power_resource" = "1" + chip drivers/i2c/hid + register "generic.hid" = ""ELAN90FC"" + register "generic.desc" = ""ELAN Touchscreen"" + register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPIO_212_IRQ)" + register "generic.probed" = "1" + register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_105)" + register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_146)" + register "generic.reset_delay_ms" = "20" + register "generic.has_power_resource" = "1" + register "generic.disable_gpio_export_in_crs" = "1" + register "hid_desc_reg_offset" = "0x01" device i2c 10 on end end chip drivers/i2c/hid