Change in ...coreboot[master]: mb/intel/coffeelake_rvp: Select CHROMEOS for CFL-U and WHL-U RVP

[Subrata Banik (Code Review)]

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31214

Change subject: mb/intel/coffeelake_rvp: Select CHROMEOS for CFL-U and WHL-U RVP
......................................................................

mb/intel/coffeelake_rvp: Select CHROMEOS for CFL-U and WHL-U RVP

This patch ensures to select chromeos kconfig only for required
CFL-U and WHL-U RVPs supported by Intel Client team.

TEST=Ensure CONFIG_GBB_FLAG_FORCE_MANUAL_RECOVERY is only selected
for CFL-U and WHL-U boards.

Change-Id: Ib61409402a948f8d5f91130e200c45320ea13d3d
Signed-off-by: Subrata Banik 
---
M src/mainboard/intel/coffeelake_rvp/Kconfig
1 file changed, 6 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/31214/1

diff --git a/src/mainboard/intel/coffeelake_rvp/Kconfig b/src/mainboard/intel/coffeelake_rvp/Kconfig
index 1019805..fbfcc0f 100644
--- a/src/mainboard/intel/coffeelake_rvp/Kconfig
+++ b/src/mainboard/intel/coffeelake_rvp/Kconfig
@@ -44,6 +44,12 @@
    default "Intel_whlrvp" if BOARD_INTEL_WHISKEYLAKE_RVP
    default "Intel_cflrvp"

+config CHROMEOS
+	bool
+	default n if BOARD_INTEL_COFFEELAKE_RVP11 || BOARD_INTEL_COFFEELAKE_RVP8
+	default y
+	select GBB_FLAG_FORCE_MANUAL_RECOVERY
+
 config MAX_CPUS
    int
    default 12 if BOARD_INTEL_COFFEELAKE_RVP11 || BOARD_INTEL_COFFEELAKE_RVP8

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31214 )

Change subject: mb/intel/coffeelake_rvp: Select CHROMEOS for CFL-U and WHL-U RVP
......................................................................

Patch Set 1: Code-Review+2

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31214 )

Change subject: mb/intel/coffeelake_rvp: Select CHROMEOS for CFL-U and WHL-U RVP
......................................................................

Patch Set 1:

(1 comment)

Is this just about the defaults or about something
the boards can't do? If the former, you can ignore
my inline comment.

https://review.coreboot.org/#/c/31214/1/src/mainboard/intel/coffeelake_rvp/K... 
File src/mainboard/intel/coffeelake_rvp/Kconfig:

https://review.coreboot.org/#/c/31214/1/src/mainboard/intel/coffeelake_rvp/K... 
PS1, Line 49: 	default n if BOARD_INTEL_COFFEELAKE_RVP11 || BOARD_INTEL_COFFEELAKE_RVP8
The `config CHROMEOS` is about building for cros
not if the board is compatible. If I understand
the commit message correctly these boards don't
support it, do they? If that's the case, please
don't `select MAINBOARD_HAS_CHROMEOS` for them
above and make this a dependency here.

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31214 )

Change subject: mb/intel/coffeelake_rvp: Select CHROMEOS for CFL-U and WHL-U RVP
......................................................................

Patch Set 1:
> (1 comment)
>
> Is this just about the defaults

@Nico, its just about default selection. So we are good with this CL ?
> or about something
> the boards can't do? If the former, you can ignore
> my inline comment.

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31214 )

Change subject: mb/intel/coffeelake_rvp: Select CHROMEOS for CFL-U and WHL-U RVP
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/31214/1/src/mainboard/intel/coffeelake_rvp/K... 
File src/mainboard/intel/coffeelake_rvp/Kconfig:

https://review.coreboot.org/#/c/31214/1/src/mainboard/intel/coffeelake_rvp/K... 
PS1, Line 49: 	default n if BOARD_INTEL_COFFEELAKE_RVP11 || BOARD_INTEL_COFFEELAKE_RVP8
> The `config CHROMEOS` is about building for cros […]

all boards are capable of building chromeos, it just that some board are maintained by certain team and we don't want to be disturbance for others :)

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31214 )

Change subject: mb/intel/coffeelake_rvp: Select CHROMEOS for CFL-U and WHL-U RVP
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/31214/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/31214/1//COMMIT_MSG@10 
PS1, Line 10: Client
client?

[Subrata Banik (Code Review)]

Hello Aaron Durbin, PraveenX Hodagatta Pranesh, Aamir Bohra, Duncan Laurie, build bot (Jenkins), Lijian Zhao, Furquan Shaikh, Patrick Georgi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31214

to look at the new patch set (#2).

Change subject: mb/intel/coffeelake_rvp: Select CHROMEOS for CFL-U and WHL-U RVP
......................................................................

mb/intel/coffeelake_rvp: Select CHROMEOS for CFL-U and WHL-U RVP

This patch ensures to select chromeos kconfig only for required
CFL-U and WHL-U RVPs supported by Intel client team.

TEST=Ensure CONFIG_GBB_FLAG_FORCE_MANUAL_RECOVERY is only selected
for CFL-U and WHL-U boards.

Change-Id: Ib61409402a948f8d5f91130e200c45320ea13d3d
Signed-off-by: Subrata Banik 
---
M src/mainboard/intel/coffeelake_rvp/Kconfig
1 file changed, 6 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/31214/2

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31214 )

Change subject: mb/intel/coffeelake_rvp: Select CHROMEOS for CFL-U and WHL-U RVP
......................................................................

Patch Set 2: Code-Review+1
> > Is this just about the defaults
>
> @Nico, its just about default selection. So we are good with this CL ?

Yap, looks good.

NB. I fear Jenkins doesn't build test w/o CHROMEOS if it
defaults to `y`. Need to investigate that further.

[Nico Huber (Code Review)]

Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31214 )

Change subject: mb/intel/coffeelake_rvp: Select CHROMEOS for CFL-U and WHL-U RVP
......................................................................

mb/intel/coffeelake_rvp: Select CHROMEOS for CFL-U and WHL-U RVP

This patch ensures to select chromeos kconfig only for required
CFL-U and WHL-U RVPs supported by Intel client team.

TEST=Ensure CONFIG_GBB_FLAG_FORCE_MANUAL_RECOVERY is only selected
for CFL-U and WHL-U boards.

Change-Id: Ib61409402a948f8d5f91130e200c45320ea13d3d
Signed-off-by: Subrata Banik 
Reviewed-on: https://review.coreboot.org/c/31214
Reviewed-by: Nico Huber 
Reviewed-by: Furquan Shaikh 
Tested-by: build bot (Jenkins) 
---
M src/mainboard/intel/coffeelake_rvp/Kconfig
1 file changed, 6 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Nico Huber: Looks good to me, but someone else must approve
  Furquan Shaikh: Looks good to me, approved

diff --git a/src/mainboard/intel/coffeelake_rvp/Kconfig b/src/mainboard/intel/coffeelake_rvp/Kconfig
index 1019805..fbfcc0f 100644
--- a/src/mainboard/intel/coffeelake_rvp/Kconfig
+++ b/src/mainboard/intel/coffeelake_rvp/Kconfig
@@ -44,6 +44,12 @@
    default "Intel_whlrvp" if BOARD_INTEL_WHISKEYLAKE_RVP
    default "Intel_cflrvp"

+config CHROMEOS
+	bool
+	default n if BOARD_INTEL_COFFEELAKE_RVP11 || BOARD_INTEL_COFFEELAKE_RVP8
+	default y
+	select GBB_FLAG_FORCE_MANUAL_RECOVERY
+
 config MAX_CPUS
    int
    default 12 if BOARD_INTEL_COFFEELAKE_RVP11 || BOARD_INTEL_COFFEELAKE_RVP8