Change in coreboot[master]: cpu/x86/smm: Use struct region to check overlapping sections - coreboot-gerrit

1 Jun 2022


      Attention is currently required from: Paul Menzel, Arthur Heymans, Tim Wawrzynczak.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63602 )
Change subject: cpu/x86/smm: Use struct region to check overlapping sections
......................................................................
Patch Set 22:
(1 comment)
File src/cpu/x86/smm/smm_module_loader.c:
https://review.coreboot.org/c/coreboot/+/63602/comment/37f986e3_72daeb35 
PS21, Line 371: 	for (region_counter; region_counter < SMM_REGIONS_ARRAY_SIZE; region_counter++)
IMHO region_counter; here without assignment to zero looks a bit odd.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/63602
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib7e2e3ae16c223ecfd8d5bce6ff6c17c53496925
Gerrit-Change-Number: 63602
Gerrit-PatchSet: 22
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Arthur Heymans arthur.heymans@9elements.com
Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@google.com
Gerrit-Comment-Date: Wed, 01 Jun 2022 11:42:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment