HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40614 )
Change subject: (test) -Werror=unused-variable ......................................................................
(test) -Werror=unused-variable
Change-Id: I3ee9b577fbd9ba2443fbbd22380e0b3fd368b633 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M Makefile.inc 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/40614/1
diff --git a/Makefile.inc b/Makefile.inc index e315732..0ce6c4d 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -421,7 +421,7 @@ CFLAGS_common += -nostdlib -Wall -Wundef -Wstrict-prototypes -Wmissing-prototypes CFLAGS_common += -Wwrite-strings -Wredundant-decls -Wno-trigraphs -Wimplicit-fallthrough CFLAGS_common += -Wstrict-aliasing -Wshadow -Wdate-time -Wtype-limits -Wvla -CFLAGS_common += -Wlogical-op -Wduplicated-cond -Wdangling-else +CFLAGS_common += -Wlogical-op -Wduplicated-cond -Wdangling-else -unused-variable CFLAGS_common += -fno-common -ffreestanding -fno-builtin -fomit-frame-pointer CFLAGS_common += -ffunction-sections -fdata-sections -fno-pie ifeq ($(CONFIG_COMPILER_GCC),y)
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40614 )
Change subject: (test) -Werror=unused-variable ......................................................................
Patch Set 1:
hum, this https://qa.coreboot.org/job/coreboot-gerrit/123651/testReport/junit/(root)/b... isn't detected
Hello build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40614
to look at the new patch set (#2).
Change subject: (test) -Werror=unused-variable ......................................................................
(test) -Werror=unused-variable
Change-Id: I3ee9b577fbd9ba2443fbbd22380e0b3fd368b633 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M Makefile.inc 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/40614/2
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40614 )
Change subject: (test) -Werror=unused-variable ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40614/3/Makefile.inc File Makefile.inc:
https://review.coreboot.org/c/coreboot/+/40614/3/Makefile.inc@411 PS3, Line 411: -Wunused-variable humm, my mistake ! "-Wall" turns on "-Wunused-variable" ...
Hello build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40614
to look at the new patch set (#4).
Change subject: (test) -Wunused-but-set-parameter ......................................................................
(test) -Wunused-but-set-parameter
Change-Id: I3ee9b577fbd9ba2443fbbd22380e0b3fd368b633 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M Makefile.inc 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/40614/4
Hello build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40614
to look at the new patch set (#5).
Change subject: (test) -Wunused-but-set-parameter ......................................................................
(test) -Wunused-but-set-parameter
Change-Id: I3ee9b577fbd9ba2443fbbd22380e0b3fd368b633 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M Makefile.inc 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/40614/5
Hello build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40614
to look at the new patch set (#6).
Change subject: Makefile.inc: Add '-Wunused-but-set-parameter' warning option ......................................................................
Makefile.inc: Add '-Wunused-but-set-parameter' warning option
Change-Id: I3ee9b577fbd9ba2443fbbd22380e0b3fd368b633 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M Makefile.inc 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/40614/6
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40614 )
Change subject: Makefile.inc: Add '-Wunused-but-set-parameter' warning option ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40614/3/Makefile.inc File Makefile.inc:
https://review.coreboot.org/c/coreboot/+/40614/3/Makefile.inc@411 PS3, Line 411: -Wunused-variable
humm, my mistake ! […]
Done
Hello build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40614
to look at the new patch set (#7).
Change subject: Makefile.inc: Add some warning options ......................................................................
Makefile.inc: Add some warning options
Added: -Wmisleading-indentation -Wmissing-include-dirs -Wshift-negative-value -Wunused -Wunused-but-set-parameter -Wsystem-headers -Wunknown-pragmas -Wmissing-parameter-type -Woverride-init -Winvalid-pch -Wunused-but-set-parameter
Change-Id: I3ee9b577fbd9ba2443fbbd22380e0b3fd368b633 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M Makefile.inc 1 file changed, 5 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/40614/7
Hello build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40614
to look at the new patch set (#8).
Change subject: Makefile.inc: Add some warning options ......................................................................
Makefile.inc: Add some warning options
Added: -Wmisleading-indentation -Wshift-negative-value -Wunused -Wunused-but-set-parameter -Wsystem-headers -Wunknown-pragmas -Wmissing-parameter-type -Woverride-init -Winvalid-pch -Wunused-but-set-parameter
Change-Id: I3ee9b577fbd9ba2443fbbd22380e0b3fd368b633 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M Makefile.inc 1 file changed, 5 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/40614/8
Hello build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40614
to look at the new patch set (#9).
Change subject: Makefile.inc: Add some warning options ......................................................................
Makefile.inc: Add some warning options
Added: -Wmisleading-indentation -Wshift-negative-value -Wunused -Wunused-but-set-parameter -Wsystem-headers -Wunknown-pragmas -Wmissing-parameter-type -Woverride-init -Winvalid-pch -Wunused-but-set-parameter
Change-Id: I3ee9b577fbd9ba2443fbbd22380e0b3fd368b633 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M Makefile.inc 1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/40614/9
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40614 )
Change subject: Makefile.inc: Add some warning options ......................................................................
Patch Set 9: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/40614/9//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40614/9//COMMIT_MSG@9 PS9, Line 9: Added: Present tense: Add
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Paul Menzel,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40614
to look at the new patch set (#10).
Change subject: Makefile.inc: Add some warning options ......................................................................
Makefile.inc: Add some warning options
Add: -Wmisleading-indentation -Wshift-negative-value -Wunused -Wunused-but-set-parameter -Wsystem-headers -Wunknown-pragmas -Wmissing-parameter-type -Woverride-init -Winvalid-pch -Wunused-but-set-parameter
Change-Id: I3ee9b577fbd9ba2443fbbd22380e0b3fd368b633 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M Makefile.inc 1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/40614/10
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Paul Menzel,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40614
to look at the new patch set (#11).
Change subject: Makefile.inc: Add some warning options ......................................................................
Makefile.inc: Add some warning options
Add: -Wmisleading-indentation -Wshift-negative-value -Wunused -Wunused-but-set-parameter -Wsystem-headers -Wunknown-pragmas -Wmissing-parameter-type -Winvalid-pch -Wunused-but-set-parameter
Change-Id: I3ee9b577fbd9ba2443fbbd22380e0b3fd368b633 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M Makefile.inc 1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/40614/11
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Paul Menzel,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40614
to look at the new patch set (#12).
Change subject: Makefile.inc: Add some warning options ......................................................................
Makefile.inc: Add some warning options
Add: -Wmisleading-indentation -Wshift-negative-value -Wunused -Wunused-but-set-parameter -Wsystem-headers -Wunknown-pragmas -Wmissing-parameter-type -Winvalid-pch -Wunused-but-set-parameter
Change-Id: I3ee9b577fbd9ba2443fbbd22380e0b3fd368b633 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M Makefile.inc 1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/40614/12
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/40614 )
Change subject: Makefile.inc: Add some warning options ......................................................................
Abandoned