Attention is currently required from: Furquan Shaikh, Justin TerAvest, Sumeet R Pawnikar, Todd Broch, Aaron Durbin, Patrick Rudolph, Karthik Ramasubramanian.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50127 )
Change subject: drivers/intel/dptf: Add OEM variables support
......................................................................
Patch Set 8:
(2 comments)
File src/drivers/intel/dptf/dptf.c:
https://review.coreboot.org/c/coreboot/+/50127/comment/604a361b_8bb0a436
PS8, Line 126: dptf_device_hid
Just double checking this device should use the same _HID as the DPTF device? I don't think I saw anything mentioned in the BWG.
File src/include/acpi/acpigen_dptf.h:
https://review.coreboot.org/c/coreboot/+/50127/comment/4573a2af_104332c3
PS8, Line 117: uint8_t oem0;
: uint8_t oem1;
: uint8_t oem2;
: uint8_t oem3;
: uint8_t oem4;
: uint8_t oem5;
: };
suggestion: representing this as an array will simplify the code, e.g. you can use a loop to write out the values.
Also IIRC these were DWORDs (uint32_t) not BYTEs (uint8_t)?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50127
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaf3cf7b40e9a441b41d0c659d76895a58669c2fb
Gerrit-Change-Number: 50127
Gerrit-PatchSet: 8
Gerrit-Owner: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Todd Broch
tbroch@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Justin TerAvest
teravest@chromium.org
Gerrit-Attention: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Attention: Todd Broch
tbroch@chromium.org
Gerrit-Attention: Aaron Durbin
adurbin@chromium.org
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Wed, 12 May 2021 22:30:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment