Attention is currently required from: Jérémy Compostella, Martin L Roth, Subrata Banik.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75905?usp=email )
Change subject: Makefile.inc: Compress DSDT file
......................................................................
Patch Set 4:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/75905/comment/a47a0e12_e12c436a :
PS4, Line 9: dsdt
`s/dsdt/DSDT ACPI table/`
Done
https://review.coreboot.org/c/coreboot/+/75905/comment/e7f88285_4826cef3 :
PS4, Line 11: 128K
I believe you meant 64 KiB.
Done
File Makefile.inc:
https://review.coreboot.org/c/coreboot/+/75905/comment/3391b7da_b36e972a :
PS4, Line 300: LZMA
We have been using lower case for compression algorithm in most places according to `grep` so I woul […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75905?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3f555b1761c7ef4943d8de447ab299684403214b
Gerrit-Change-Number: 75905
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Comment-Date: Tue, 20 Feb 2024 11:50:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-MessageType: comment