Attention is currently required from: Furquan Shaikh, Jakub Czapiga. Ricardo Quesada has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57869 )
Change subject: elogtool: add pytest for elogtool ......................................................................
Patch Set 6:
(4 comments)
Patchset:
PS6: ty. fixed.
File util/cbfstool/tests/README.md:
https://review.coreboot.org/c/coreboot/+/57869/comment/173ea377_e2d92590 PS5, Line 26: ```
From checkpath: "util/cbfstool/tests/README.md has no final newline. […]
Done
File util/cbfstool/tests/elogtool_test.py:
https://review.coreboot.org/c/coreboot/+/57869/comment/29d494e9_46fb06f3 PS5, Line 38: bin
`bin` is Python's way to convert values to binary form. This is reserved name. […]
Done
https://review.coreboot.org/c/coreboot/+/57869/comment/f62e8973_c339b277 PS5, Line 108: 8 + 4 + 1
Might be nice to define header and checksum size as constants. […]
done. defined a global ELOG_EVENT_HEADER_SIZE + ELOG_EVENT_CHECKSUM_SIZE. And locally defined data_size, which is used twice in the function.
-
Ricardo Quesada (Code Review)