Ian Feng has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44012 )
Change subject: mb/google/dedede/var/madoo: Enable Goodix touchscreen ......................................................................
mb/google/dedede/var/madoo: Enable Goodix touchscreen
Add Goodix touchscreen support.
BUG=b:160868197 TEST=emerge-dedede coreboot chromeos-bootimage", build successful
Signed-off-by: Ian Feng ian_feng@compal.corp-partner.google.com Change-Id: I9bf27d69d0895cb4ea8620a6da49e98d25e05c23 --- M src/mainboard/google/dedede/variants/madoo/overridetree.cb 1 file changed, 17 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/44012/1
diff --git a/src/mainboard/google/dedede/variants/madoo/overridetree.cb b/src/mainboard/google/dedede/variants/madoo/overridetree.cb index e189ec3..f8e2b06 100644 --- a/src/mainboard/google/dedede/variants/madoo/overridetree.cb +++ b/src/mainboard/google/dedede/variants/madoo/overridetree.cb @@ -57,7 +57,23 @@ end end # USB xHCI device pci 15.0 on end - device pci 15.2 on end + device pci 15.2 on + chip drivers/i2c/hid + register "generic.hid" = ""GDIX0000"" + register "generic.desc" = ""Goodix Touchscreen"" + register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_D4_IRQ)" + register "generic.probed" = "1" + register "generic.reset_gpio" = + "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D5)" + register "generic.reset_delay_ms" = "120" + register "generic.reset_off_delay_ms" = "2" + register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D6)" + register "generic.enable_delay_ms" = "12" + register "generic.has_power_resource" = "1" + register "hid_desc_reg_offset" = "0x01" + device i2c 0x5d on end + end + end # I2C 2 device pci 1c.7 on end device pci 19.0 on chip drivers/i2c/generic
Ian Feng has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/44012 )
Change subject: mb/google/dedede/var/madoo: Enable Goodix touchscreen ......................................................................
mb/google/dedede/var/madoo: Enable Goodix touchscreen
Add Goodix touchscreen support.
BUG=b:160868197 BRANCH=None TEST=emerge-dedede coreboot chromeos-bootimage", build successful
Signed-off-by: Ian Feng ian_feng@compal.corp-partner.google.com Change-Id: I9bf27d69d0895cb4ea8620a6da49e98d25e05c23 --- M src/mainboard/google/dedede/variants/madoo/overridetree.cb 1 file changed, 17 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/44012/2
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44012 )
Change subject: mb/google/dedede/var/madoo: Enable Goodix touchscreen ......................................................................
Patch Set 2: Code-Review+1
Dtrain Hsu has uploaded a new patch set (#4) to the change originally created by Ian Feng. ( https://review.coreboot.org/c/coreboot/+/44012 )
Change subject: mb/google/dedede/var/madoo: Enable Goodix touchscreen ......................................................................
mb/google/dedede/var/madoo: Enable Goodix touchscreen
Add Goodix touchscreen support.
BUG=b:160868197 BRANCH=None TEST=emerge-dedede coreboot chromeos-bootimage", build successful
Signed-off-by: Ian Feng ian_feng@compal.corp-partner.google.com Change-Id: I9bf27d69d0895cb4ea8620a6da49e98d25e05c23 --- M src/mainboard/google/dedede/variants/madoo/overridetree.cb 1 file changed, 17 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/44012/4
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44012 )
Change subject: mb/google/dedede/var/madoo: Enable Goodix touchscreen ......................................................................
Patch Set 4: Code-Review+2
Justin TerAvest has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44012 )
Change subject: mb/google/dedede/var/madoo: Enable Goodix touchscreen ......................................................................
Patch Set 4: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44012 )
Change subject: mb/google/dedede/var/madoo: Enable Goodix touchscreen ......................................................................
mb/google/dedede/var/madoo: Enable Goodix touchscreen
Add Goodix touchscreen support.
BUG=b:160868197 BRANCH=None TEST=emerge-dedede coreboot chromeos-bootimage", build successful
Signed-off-by: Ian Feng ian_feng@compal.corp-partner.google.com Change-Id: I9bf27d69d0895cb4ea8620a6da49e98d25e05c23 Reviewed-on: https://review.coreboot.org/c/coreboot/+/44012 Reviewed-by: Karthik Ramasubramanian kramasub@google.com Reviewed-by: Justin TerAvest teravest@chromium.org Reviewed-by: EricR Lai ericr_lai@compal.corp-partner.google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/dedede/variants/madoo/overridetree.cb 1 file changed, 17 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Justin TerAvest: Looks good to me, approved Karthik Ramasubramanian: Looks good to me, approved EricR Lai: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/dedede/variants/madoo/overridetree.cb b/src/mainboard/google/dedede/variants/madoo/overridetree.cb index e189ec3..f8e2b06 100644 --- a/src/mainboard/google/dedede/variants/madoo/overridetree.cb +++ b/src/mainboard/google/dedede/variants/madoo/overridetree.cb @@ -57,7 +57,23 @@ end end # USB xHCI device pci 15.0 on end - device pci 15.2 on end + device pci 15.2 on + chip drivers/i2c/hid + register "generic.hid" = ""GDIX0000"" + register "generic.desc" = ""Goodix Touchscreen"" + register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_D4_IRQ)" + register "generic.probed" = "1" + register "generic.reset_gpio" = + "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D5)" + register "generic.reset_delay_ms" = "120" + register "generic.reset_off_delay_ms" = "2" + register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D6)" + register "generic.enable_delay_ms" = "12" + register "generic.has_power_resource" = "1" + register "hid_desc_reg_offset" = "0x01" + device i2c 0x5d on end + end + end # I2C 2 device pci 1c.7 on end device pci 19.0 on chip drivers/i2c/generic
-
Dtrain Hsu (Code Review) -
EricR Lai (Code Review)
-
Ian Feng (Code Review)
-
Justin TerAvest (Code Review)
-
Karthik Ramasubramanian (Code Review)
-
Patrick Georgi (Code Review)