Attention is currently required from: Anjaneya "Reddy" Chagam, Jonathan Zhang, Johnny Lin, Arthur Heymans, Morgan Jang, Patrick Rudolph. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54093 )
Change subject: security/intel/cbnt: Add logging ......................................................................
Patch Set 2:
(9 comments)
File src/security/intel/cbnt/logging.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119158): https://review.coreboot.org/c/coreboot/+/54093/comment/597dafb5_bb7aa45a PS2, Line 21: uint64_t : 24; space prohibited before that ':' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119158): https://review.coreboot.org/c/coreboot/+/54093/comment/e35b58fe_00a3b87c PS2, Line 23: uint64_t : 1; space prohibited before that ':' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119158): https://review.coreboot.org/c/coreboot/+/54093/comment/1dcb67e8_439de789 PS2, Line 25: uint64_t : 29; space prohibited before that ':' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119158): https://review.coreboot.org/c/coreboot/+/54093/comment/ce73c894_0bbdb162 PS2, Line 32: static const char *tpm_type[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119158): https://review.coreboot.org/c/coreboot/+/54093/comment/ac207c1c_755c59f8 PS2, Line 41: uint64_t : 59; space prohibited before that ':' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119158): https://review.coreboot.org/c/coreboot/+/54093/comment/508c7f53_de0c5f6f PS2, Line 56: uint32_t : 15; space prohibited before that ':' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119158): https://review.coreboot.org/c/coreboot/+/54093/comment/2c4271d3_94cbc6c6 PS2, Line 66: uint32_t : 5; space prohibited before that ':' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119158): https://review.coreboot.org/c/coreboot/+/54093/comment/ea94308c_ff0528d0 PS2, Line 83: uint32_t : 2; space prohibited before that ':' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119158): https://review.coreboot.org/c/coreboot/+/54093/comment/fa1a0181_b5472e2c PS2, Line 94: uint32_t : 6; space prohibited before that ':' (ctx:WxW)