Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55811 )
Change subject: soc/intel/broadwell: Consolidate SPD handling
......................................................................
Patch Set 14:
(1 comment)
File src/mainboard/intel/wtm2/pei_data.c:
https://review.coreboot.org/c/coreboot/+/55811/comment/1cb6c7e9_0ebe60cc
PS14, Line 8: spdi->addresses[0] = 0x51;
: spdi->addresses[2] = 0x51;
This has been wrong since coreboot 4.4 so it's either an ancient mistake or it's just a weird board.
CB:2725 already had this issue
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55811
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I92a05003a319c354675368cae8e34980bd2f9e10
Gerrit-Change-Number: 55811
Gerrit-PatchSet: 14
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Jonathon Hall
jonathon.hall@puri.sm
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Elyes Haouas
ehaouas@noos.fr
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Mon, 05 Sep 2022 21:37:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Elyes Haouas
ehaouas@noos.fr
Gerrit-MessageType: comment