Change in coreboot[master]: soc/intel/denverton_ns: make use of common cbmem_top_chipset - coreboot-gerrit

11 Nov 2019


      David Guckian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36619 )
Change subject: soc/intel/denverton_ns: make use of common cbmem_top_chipset
......................................................................
Patch Set 5: Code-Review+1
...
Patch Set 5:
...
Given that Intel support for this platform was 'drop and leave', LGTM and worry later if it regresses things.
It's not really abandoned, afaict.
Can somebody test this? David, Vanessa, Julien?
Apologies, I thought I had already replied to this review.
I have tested this change, its working on DNV system.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/36619
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idae96aabe2807e465bb7ab0f29910757d0346ce9
Gerrit-Change-Number: 36619
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: David Guckian
Gerrit-Reviewer: David Guckian david.guckian@intel.com
Gerrit-Reviewer: Julien Viard de Galbert coreboot-review-ju@vdg.name
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Vanny E vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 11 Nov 2019 12:39:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment