Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35402 )
Change subject: soc/intel/common/block/cse: Add boot partition related APIs
......................................................................
Patch Set 42:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35402/38//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/35402/38//COMMIT_MSG@17
PS38, Line 17: below APIs
This patch is adding more than the 2 APIs to the header file. […]
Since the patch has been reviewed multiple times by community,so I think splitting the patch now does not sounds good! Thanks.
https://review.coreboot.org/c/coreboot/+/35402/40/src/soc/intel/common/block...
File src/soc/intel/common/block/cse/cse_bp.c:
https://review.coreboot.org/c/coreboot/+/35402/40/src/soc/intel/common/block...
PS40, Line 182: return false;
Above you print an error.
cse_init_bp_info() logs error message if something goes wrong inside of the function.So, I think adding one more log will be reduandant. Thanks Paul.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35402
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaa62409c0616d5913d21374a8a6804f82258eb4f
Gerrit-Change-Number: 35402
Gerrit-PatchSet: 42
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Andrey Petrov
anpetrov@fb.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Sridhar Siricilla
sridhar.siricilla@intel.corp-partner.google.com
Gerrit-Comment-Date: Fri, 20 Dec 2019 11:33:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Rizwan Qureshi
rizwan.qureshi@intel.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment