Change in coreboot[master]: util/intelp2m/snr: Remove incorrent GPO macro

List overview All Threads
Download

newer

older

Change in coreboot[master]: [WIP]...

Change in coreboot[master]:...

Maxim Polyakov (Code Review)

14 Aug 2020 14 Aug '20

6:17 p.m.

Maxim Polyakov has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44472 )

Change subject: util/intelp2m/snr: Remove incorrent GPO macro ......................................................................

util/intelp2m/snr: Remove incorrent GPO macro

GPIO Driver mode is used for configuration interrupt routing for external devices through GPI. But there is no point in configuring this for GPO and according to the changes in the project [1], this patch removes the code to generate PAD_CFG_GPO_GPIO_DRIVER macro.

[1] Change-Id: I74c318897647836f4604a937543254f44b470433

Change-Id: Ibe7b787d455b638e70e54fb8b048c8aad8283037 Signed-off-by: Maxim Polyakov max.senia.poliak@gmail.com --- M util/intelp2m/platforms/snr/macro.go 1 file changed, 0 insertions(+), 5 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/44472/1

diff --git a/util/intelp2m/platforms/snr/macro.go b/util/intelp2m/platforms/snr/macro.go index 86cc7b7..3340ec0 100644 --- a/util/intelp2m/platforms/snr/macro.go +++ b/util/intelp2m/platforms/snr/macro.go @@ -213,11 +213,6 @@ dw0.CntrMaskFieldsClear(common.RxLevelEdgeConfigurationMask) } macro.Set("PAD_CFG") - if macro.IsOwnershipDriver() { - // PAD_CFG_GPO_GPIO_DRIVER(pad, val, rst, pull) - macro.Add("_GPO_GPIO_DRIVER").Add("(").Id().Val().Rstsrc().Pull().Add("),") - return - } if term != 0 { // e.g. PAD_CFG_TERM_GPO(GPP_B23, 1, DN_20K, DEEP), macro.Add("_TERM")

Attachments:

attachment.htm (text/html — 3.1 KB)

Show replies by date

Paul Menzel (Code Review)

1 Sep 1 Sep

9:26 a.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44472 )

Change subject: util/intelp2m/snr: Remove incorrent GPO macro ......................................................................

Patch Set 2:

(3 comments)

https://review.coreboot.org/c/coreboot/+/44472/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/44472/2//COMMIT_MSG@7 PS2, Line 7: incorrent incorrect

https://review.coreboot.org/c/coreboot/+/44472/2//COMMIT_MSG@9 PS2, Line 9: Driver driver?

https://review.coreboot.org/c/coreboot/+/44472/2//COMMIT_MSG@11 PS2, Line 11: the changes in the project [1] It’d be great if you added the hash too.

...

… according to commit … (…), …

-- To view, visit https://review.coreboot.org/c/coreboot/+/44472 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibe7b787d455b638e70e54fb8b048c8aad8283037 Gerrit-Change-Number: 44472 Gerrit-PatchSet: 2 Gerrit-Owner: Maxim Polyakov max.senia.poliak@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 01 Sep 2020 09:26:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Maxim Polyakov (Code Review)

8 Sep 8 Sep

7:15 a.m.

New subject: Change in coreboot[master]: util/intelp2m/snr: Remove incorreсt GPO macro

Hello build bot (Jenkins), Paul Menzel, Angel Pons,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/44472

to look at the new patch set (#3).

Change subject: util/intelp2m/snr: Remove incorreсt GPO macro ......................................................................

util/intelp2m/snr: Remove incorreсt GPO macro

GPIO driver mode is used for configuration interrupt routing for external devices through GPI. But there is no point in configuring this for GPO and according to the commit 7ccf31a0 [1], this patch removes the code to generate PAD_CFG_GPO_GPIO_DRIVER macro.

[1] https://review.coreboot.org/c/coreboot/+/44471

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/44472/3

Maxim Polyakov (Code Review)

11:07 a.m.

New subject: Change in coreboot[master]: util/intelp2m/snr: Remove incorreсt GPO macro

Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44472 )

Change subject: util/intelp2m/snr: Remove incorreсt GPO macro ......................................................................

Patch Set 3:

(3 comments)

https://review.coreboot.org/c/coreboot/+/44472/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/44472/2//COMMIT_MSG@7 PS2, Line 7: incorrent

...

incorrect

Done

https://review.coreboot.org/c/coreboot/+/44472/2//COMMIT_MSG@9 PS2, Line 9: Driver

...

driver?

Done

https://review.coreboot.org/c/coreboot/+/44472/2//COMMIT_MSG@11 PS2, Line 11: the changes in the project [1]

...

It’d be great if you added the hash too. […]

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/44472 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibe7b787d455b638e70e54fb8b048c8aad8283037 Gerrit-Change-Number: 44472 Gerrit-PatchSet: 3 Gerrit-Owner: Maxim Polyakov max.senia.poliak@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Mario Scheithauer mario.scheithauer@siemens.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 08 Sep 2020 11:07:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Mario Scheithauer (Code Review)

11:12 a.m.

New subject: Change in coreboot[master]: util/intelp2m/snr: Remove incorreсt GPO macro

Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44472 )

Change subject: util/intelp2m/snr: Remove incorreсt GPO macro ......................................................................

Patch Set 3: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/44472 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibe7b787d455b638e70e54fb8b048c8aad8283037 Gerrit-Change-Number: 44472 Gerrit-PatchSet: 3 Gerrit-Owner: Maxim Polyakov max.senia.poliak@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Mario Scheithauer mario.scheithauer@siemens.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 08 Sep 2020 11:12:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Michael Niewöhner (Code Review)

15 Sep 15 Sep

10:28 a.m.

New subject: Change in coreboot[master]: util/intelp2m/snr: Remove incorreсt GPO macro

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44472 )

Change subject: util/intelp2m/snr: Remove incorreсt GPO macro ......................................................................

Patch Set 3:

well, not sure about this and GPIO driver mode at all; see https://review.coreboot.org/c/coreboot/+/44471/2//COMMIT_MSG#11

-- To view, visit https://review.coreboot.org/c/coreboot/+/44472 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibe7b787d455b638e70e54fb8b048c8aad8283037 Gerrit-Change-Number: 44472 Gerrit-PatchSet: 3 Gerrit-Owner: Maxim Polyakov max.senia.poliak@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Mario Scheithauer mario.scheithauer@siemens.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Michael Niewöhner foss@mniewoehner.de Gerrit-Comment-Date: Tue, 15 Sep 2020 10:28:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Matt DeVillier (Code Review)

9:38 p.m.

New subject: Change in coreboot[master]: util/intelp2m/snr: Remove incorreсt GPO macro

Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44472 )

Change subject: util/intelp2m/snr: Remove incorreсt GPO macro ......................................................................

Patch Set 3: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/44472 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibe7b787d455b638e70e54fb8b048c8aad8283037 Gerrit-Change-Number: 44472 Gerrit-PatchSet: 3 Gerrit-Owner: Maxim Polyakov max.senia.poliak@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Mario Scheithauer mario.scheithauer@siemens.com Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Michael Niewöhner foss@mniewoehner.de Gerrit-Comment-Date: Tue, 15 Sep 2020 21:38:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Matt DeVillier (Code Review)

8 Oct 8 Oct

6:41 a.m.

New subject: Change in coreboot[master]: util/intelp2m/snr: Remove incorreсt GPO macro

Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44472 )

Change subject: util/intelp2m/snr: Remove incorreсt GPO macro ......................................................................

Patch Set 4: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/44472 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibe7b787d455b638e70e54fb8b048c8aad8283037 Gerrit-Change-Number: 44472 Gerrit-PatchSet: 4 Gerrit-Owner: Maxim Polyakov max.senia.poliak@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Mario Scheithauer mario.scheithauer@siemens.com Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Michael Niewöhner foss@mniewoehner.de Gerrit-Comment-Date: Thu, 08 Oct 2020 06:41:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Michael Niewöhner (Code Review)

10 Oct 10 Oct

8:13 p.m.

New subject: Change in coreboot[master]: util/intelp2m/snr: Remove incorreсt GPO macro

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44472 )

Change subject: util/intelp2m/snr: Remove incorreсt GPO macro ......................................................................

Patch Set 4:

(1 comment)

see CB:44471

https://review.coreboot.org/c/coreboot/+/44472/4//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/44472/4//COMMIT_MSG@9 PS4, Line 9: GPIO driver mode is used for configuration interrupt routing for : external devices through GPI. But there is no point in configuring : this for GPO see CB:44471

-- To view, visit https://review.coreboot.org/c/coreboot/+/44472 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibe7b787d455b638e70e54fb8b048c8aad8283037 Gerrit-Change-Number: 44472 Gerrit-PatchSet: 4 Gerrit-Owner: Maxim Polyakov max.senia.poliak@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Mario Scheithauer mario.scheithauer@siemens.com Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Michael Niewöhner foss@mniewoehner.de Gerrit-Comment-Date: Sat, 10 Oct 2020 20:13:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Maxim Polyakov (Code Review)

17 May 17 May

12:32 p.m.

New subject: Change in coreboot[master]: util/intelp2m/snr: Remove incorreсt GPO macro

Maxim Polyakov has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/44472 )

Change subject: util/intelp2m/snr: Remove incorreсt GPO macro ......................................................................

Abandoned

-- To view, visit https://review.coreboot.org/c/coreboot/+/44472 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibe7b787d455b638e70e54fb8b048c8aad8283037 Gerrit-Change-Number: 44472 Gerrit-PatchSet: 4 Gerrit-Owner: Maxim Polyakov max.senia.poliak@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Mario Scheithauer mario.scheithauer@siemens.com Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Michael Niewöhner foss@mniewoehner.de Gerrit-MessageType: abandon

1292

days inactive

1568

days old

coreboot-gerrit@coreboot.org

9 comments

5 participants

tags (0)

participants (5)

Mario Scheithauer (Code Review)
Matt DeVillier (Code Review)
Maxim Polyakov (Code Review)
Michael Niewöhner (Code Review)
Paul Menzel (Code Review)