Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/25210 )
Change subject: sdm845: Add AOP firmware support
......................................................................
Patch Set 75:
(2 comments)
https://review.coreboot.org/#/c/25210/75/src/soc/qualcomm/sdm845/clock.c
File src/soc/qualcomm/sdm845/clock.c:
https://review.coreboot.org/#/c/25210/75/src/soc/qualcomm/sdm845/clock.c@156
PS75, Line 156: *mailbox = AOP_LOADED_SIGNAL_FLAG;
Actually, I wonder if this should be using write32() since it has asynchronous effects (similar to a hardware register write).
https://review.coreboot.org/#/c/25210/75/src/soc/qualcomm/sdm845/mmu.c
File src/soc/qualcomm/sdm845/mmu.c:
https://review.coreboot.org/#/c/25210/75/src/soc/qualcomm/sdm845/mmu.c@36
PS75, Line 36: void soc_mmu_dram_config_post_dram_init()
Bad function definition - void soc_mmu_dram_config_post_dram_init() should probably be void soc_mmu_ […]
What he said.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/25210
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9845c8638e4b905de5d6985dc9f1fddd8b1a8942
Gerrit-Change-Number: 25210
Gerrit-PatchSet: 75
Gerrit-Owner: T.Michael Turney
tturne@codeaurora.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: T Michael Turney
mturney@codeaurora.org
Gerrit-Reviewer: T.Michael Turney
tturne@codeaurora.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jonathan Neuschäfer
j.neuschaefer@gmx.net
Gerrit-Comment-Date: Mon, 15 Apr 2019 22:51:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-MessageType: comment