Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44120 )
Change subject: nb/intel/haswell: Deduplicate PCIEXBAR decoding
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/44120/4/src/northbridge/intel/haswe...
File src/northbridge/intel/haswell/northbridge.c:
https://review.coreboot.org/c/coreboot/+/44120/4/src/northbridge/intel/haswe...
PS4, Line 35: 1024 * 1024
Unrelated but MiB
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44120
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If04ca3467bb067b28605a3acccb8bda325735999
Gerrit-Change-Number: 44120
Gerrit-PatchSet: 4
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 03 Aug 2020 20:02:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment