Change in coreboot[master]: soc/mediatek/mt8183: Adjust DRAM voltages for each DRAM frequency
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35017 )
Change subject: soc/mediatek/mt8183: Adjust DRAM voltages for each DRAM frequency ......................................................................
Patch Set 14:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35017/2/src/soc/mediatek/mt8183/emi... File src/soc/mediatek/mt8183/emi.c:
https://review.coreboot.org/c/coreboot/+/35017/2/src/soc/mediatek/mt8183/emi... PS2, Line 389: #if DUAL_FREQ_K
Can you implement this without preprocessor statements?
Done
https://review.coreboot.org/c/coreboot/+/35017/5/src/soc/mediatek/mt8183/emi... File src/soc/mediatek/mt8183/emi.c:
https://review.coreboot.org/c/coreboot/+/35017/5/src/soc/mediatek/mt8183/emi... PS5, Line 47: voltage_LP4X
Use lower case variable names.
Done
-
Yu-Ping Wu (Code Review)