Hello Kevin Chiu,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/47700
to review the following change.
Change subject: mb/google/zork: update DRAM table for dirinboz ......................................................................
mb/google/zork: update DRAM table for dirinboz
Add Hynix DDR4 DRAM, index was generated by gen_part_id H5ANAG6NCJR-XNC
BUG=b:173480390 BRANCH=zork TEST=emerge-zork coreboot
Change-Id: Ib6f26a7b8d014493f4a256b328bee7ad3bf3c2b9 Signed-off-by: Kevin Chiu kevin.chiu@quantatw.com --- M src/mainboard/google/zork/variants/dirinboz/spd/Makefile.inc M src/mainboard/google/zork/variants/dirinboz/spd/dram_id.generated.txt M src/mainboard/google/zork/variants/dirinboz/spd/mem_parts_used.txt 3 files changed, 3 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/47700/1
diff --git a/src/mainboard/google/zork/variants/dirinboz/spd/Makefile.inc b/src/mainboard/google/zork/variants/dirinboz/spd/Makefile.inc index 5e09836..6d8a906 100644 --- a/src/mainboard/google/zork/variants/dirinboz/spd/Makefile.inc +++ b/src/mainboard/google/zork/variants/dirinboz/spd/Makefile.inc @@ -2,7 +2,7 @@ ## This is an auto-generated file. Do not edit!!
SPD_SOURCES = -SPD_SOURCES += ddr4-spd-empty.hex # ID = 0(0b0000) +SPD_SOURCES += ddr4-spd-9.hex # ID = 0(0b0000) Parts = H5ANAG6NCJR-XNC SPD_SOURCES += ddr4-spd-empty.hex # ID = 1(0b0001) SPD_SOURCES += ddr4-spd-3.hex # ID = 2(0b0010) Parts = K4A8G165WC-BCTD SPD_SOURCES += ddr4-spd-empty.hex # ID = 3(0b0011) diff --git a/src/mainboard/google/zork/variants/dirinboz/spd/dram_id.generated.txt b/src/mainboard/google/zork/variants/dirinboz/spd/dram_id.generated.txt index 8c8ee39..d6d5d09 100644 --- a/src/mainboard/google/zork/variants/dirinboz/spd/dram_id.generated.txt +++ b/src/mainboard/google/zork/variants/dirinboz/spd/dram_id.generated.txt @@ -7,3 +7,4 @@ MT40A1G16KD-062E:E 8 (1000) K4AAG165WA-BCTD 9 (1001) K4AAG165WA-BCWE 10 (1010) +H5ANAG6NCJR-XNC 0 (0000) diff --git a/src/mainboard/google/zork/variants/dirinboz/spd/mem_parts_used.txt b/src/mainboard/google/zork/variants/dirinboz/spd/mem_parts_used.txt index ba70da3..5a6541f 100644 --- a/src/mainboard/google/zork/variants/dirinboz/spd/mem_parts_used.txt +++ b/src/mainboard/google/zork/variants/dirinboz/spd/mem_parts_used.txt @@ -15,3 +15,4 @@ MT40A1G16KD-062E:E, 8 K4AAG165WA-BCTD, 9 K4AAG165WA-BCWE, 10 +H5ANAG6NCJR-XNC
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47700 )
Change subject: mb/google/zork: update DRAM table for dirinboz ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
LGTM, though I do have the one question.
https://review.coreboot.org/c/coreboot/+/47700/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/dirinboz/spd/mem_parts_used.txt:
https://review.coreboot.org/c/coreboot/+/47700/1/src/mainboard/google/zork/v... PS1, Line 18: H5ANAG6NCJR-XNC Why wouldn't we want to set a fixed ID for this? Note that this isn't a complaint, I'm just not completely sure how the new method works.
Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47700 )
Change subject: mb/google/zork: update DRAM table for dirinboz ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/47700/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/dirinboz/spd/mem_parts_used.txt:
https://review.coreboot.org/c/coreboot/+/47700/1/src/mainboard/google/zork/v... PS1, Line 18: H5ANAG6NCJR-XNC
Why wouldn't we want to set a fixed ID for this? Note that this isn't a complaint, I'm just not com […]
The tool will auto assign, possibly reusing an existing ID. We only set fixed id for parts that were assigned before the tool was working.
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47700 )
Change subject: mb/google/zork: update DRAM table for dirinboz ......................................................................
mb/google/zork: update DRAM table for dirinboz
Add Hynix DDR4 DRAM, index was generated by gen_part_id H5ANAG6NCJR-XNC
BUG=b:173480390 BRANCH=zork TEST=emerge-zork coreboot
Change-Id: Ib6f26a7b8d014493f4a256b328bee7ad3bf3c2b9 Signed-off-by: Kevin Chiu kevin.chiu@quantatw.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/47700 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Martin Roth martinroth@google.com Reviewed-by: Rob Barnes robbarnes@google.com --- M src/mainboard/google/zork/variants/dirinboz/spd/Makefile.inc M src/mainboard/google/zork/variants/dirinboz/spd/dram_id.generated.txt M src/mainboard/google/zork/variants/dirinboz/spd/mem_parts_used.txt 3 files changed, 3 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved Rob Barnes: Looks good to me, approved
diff --git a/src/mainboard/google/zork/variants/dirinboz/spd/Makefile.inc b/src/mainboard/google/zork/variants/dirinboz/spd/Makefile.inc index 5e09836..6d8a906 100644 --- a/src/mainboard/google/zork/variants/dirinboz/spd/Makefile.inc +++ b/src/mainboard/google/zork/variants/dirinboz/spd/Makefile.inc @@ -2,7 +2,7 @@ ## This is an auto-generated file. Do not edit!!
SPD_SOURCES = -SPD_SOURCES += ddr4-spd-empty.hex # ID = 0(0b0000) +SPD_SOURCES += ddr4-spd-9.hex # ID = 0(0b0000) Parts = H5ANAG6NCJR-XNC SPD_SOURCES += ddr4-spd-empty.hex # ID = 1(0b0001) SPD_SOURCES += ddr4-spd-3.hex # ID = 2(0b0010) Parts = K4A8G165WC-BCTD SPD_SOURCES += ddr4-spd-empty.hex # ID = 3(0b0011) diff --git a/src/mainboard/google/zork/variants/dirinboz/spd/dram_id.generated.txt b/src/mainboard/google/zork/variants/dirinboz/spd/dram_id.generated.txt index 8c8ee39..d6d5d09 100644 --- a/src/mainboard/google/zork/variants/dirinboz/spd/dram_id.generated.txt +++ b/src/mainboard/google/zork/variants/dirinboz/spd/dram_id.generated.txt @@ -7,3 +7,4 @@ MT40A1G16KD-062E:E 8 (1000) K4AAG165WA-BCTD 9 (1001) K4AAG165WA-BCWE 10 (1010) +H5ANAG6NCJR-XNC 0 (0000) diff --git a/src/mainboard/google/zork/variants/dirinboz/spd/mem_parts_used.txt b/src/mainboard/google/zork/variants/dirinboz/spd/mem_parts_used.txt index ba70da3..5a6541f 100644 --- a/src/mainboard/google/zork/variants/dirinboz/spd/mem_parts_used.txt +++ b/src/mainboard/google/zork/variants/dirinboz/spd/mem_parts_used.txt @@ -15,3 +15,4 @@ MT40A1G16KD-062E:E, 8 K4AAG165WA-BCTD, 9 K4AAG165WA-BCWE, 10 +H5ANAG6NCJR-XNC
-
Felix Held (Code Review) -
Kevin Chiu (Code Review)
-
Martin Roth (Code Review)
-
Rob Barnes (Code Review)