Attention is currently required from: Felix Singer, Michał Żygowski, Michał Kopeć, Michael Niewöhner.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62498 )
Change subject: mb/clevo/tgl-u: Add Clevo NV41 Tiger Lake laptop support
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/clevo/tgl-u/bootblock.c:
https://review.coreboot.org/c/coreboot/+/62498/comment/1ca32847_cfc052cf
PS1, Line 16: if (onoff) {
: gpio_set(DGPU_RST_N, 0);
: mdelay(4);
: gpio_set(DGPU_PWR_EN, 1);
: mdelay(4);
: gpio_set(DGPU_RST_N, 1);
: } else {
: gpio_set(DGPU_RST_N, 0);
: mdelay(4);
: gpio_set(DGPU_PWR_EN, 0);
hmm, this looks like non-board-specific, generic code, that should be located in src/driver somewher […]
Aren't the power sequence GPIOs mainboard-specific? The sequence may also depend on other stuff. For example, see CB:62384
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62498
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib373d62d9d18bafdfde2e1acb4e00e3a20ae09bc
Gerrit-Change-Number: 62498
Gerrit-PatchSet: 3
Gerrit-Owner: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Comment-Date: Sun, 01 May 2022 20:26:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment