Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48583 )
Change subject: soc/intel: hook up new gpio device in the soc chips ......................................................................
Patch Set 10:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48583/7/src/soc/intel/alderlake/chi... File src/soc/intel/alderlake/chip.c:
https://review.coreboot.org/c/coreboot/+/48583/7/src/soc/intel/alderlake/chi... PS7, Line 202: else if (dev->path.type == DEVICE_PATH_GPIO) : dev->ops = &soc_gpio_ops;
It also relieves each SoC from duplicating the same code to set up GPIO device ops. […]
I still think that it would be beneficial to have a separate chip for the GPIO device. Anyways, we can start with this and see how the use cases develop.
-
Furquan Shaikh (Code Review)