[M] Change in coreboot[master]: soc/intel/alderlake/acpi: Add Kconfig options for SCM and FCM - coreboot-gerrit

3 Jan 2023


      Attention is currently required from: Tarun Tuli, Martin L Roth, Subrata Banik, Matt DeVillier, John Zhao, Tim Wawrzynczak.
Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64561 )
Change subject: soc/intel/alderlake/acpi: Add Kconfig options for SCM and FCM
......................................................................
Patch Set 8:
(1 comment)
File src/soc/intel/alderlake/acpi/tcss.asl:
https://review.coreboot.org/c/coreboot/+/64561/comment/c81ad413_231ba43b 
PS7, Line 164: #if CONFIG(CHROMEOS)
...
...
Talking to MattD, it sounds like we don't want to use CONFIG(CHROMEOS) as the way to choose it. […]
Like PS8?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/64561
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iac31d37c0873f41f7b14e1051fe214466d1ebdd8
Gerrit-Change-Number: 64561
Gerrit-PatchSet: 8
Gerrit-Owner: Sean Rhodes sean@starlabs.systems
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: John Zhao john.zhao@intel.corp-partner.google.com
Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli taruntuli@google.com
Gerrit-Reviewer: Tim Wawrzynczak inforichland@gmail.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-CC: Martin L Roth gaumless@gmail.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Tarun Tuli taruntuli@google.com
Gerrit-Attention: Martin L Roth gaumless@gmail.com
Gerrit-Attention: Subrata Banik subratabanik@google.com
Gerrit-Attention: Matt DeVillier matt.devillier@gmail.com
Gerrit-Attention: John Zhao john.zhao@intel.corp-partner.google.com
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@google.com
Gerrit-Comment-Date: Tue, 03 Jan 2023 13:06:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin L Roth gaumless@gmail.com
Comment-In-Reply-To: Subrata Banik subratabanik@google.com
Gerrit-MessageType: comment