Change in ...coreboot[master]: src/device/dram/ddr3.c: Fix 'if' condition identical branches
HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33270
Change subject: src/device/dram/ddr3.c: Fix 'if' condition identical branches ......................................................................
src/device/dram/ddr3.c: Fix 'if' condition identical branches
When using -Werror=duplicated-branches, the compiler complain that "if (capacity_shift < 0x02)" has identical branches.
Change-Id: I9c553e97076c31e9db036c2865ad8788701d255b Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/device/dram/ddr3.c 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/33270/1
diff --git a/src/device/dram/ddr3.c b/src/device/dram/ddr3.c index 3272dac..9fe5d92 100644 --- a/src/device/dram/ddr3.c +++ b/src/device/dram/ddr3.c @@ -182,9 +182,9 @@ ret = SPD_STATUS_INVALID_FIELD; } if (capacity_shift < 0x02) { - printram(" Capacity : %u Mb\n", 256 << capacity_shift); + printk(RAM_DEBUG, " Capacity : %u Mb\n", 256 << capacity_shift); } else { - printram(" Capacity : %u Gb\n", 1 << (capacity_shift - 2)); + printk(RAM_DEBUG, " Capacity : %u Gb\n", 1 << (capacity_shift - 2)); }
reg8 = spd[5];
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33270 )
Change subject: src/device/dram/ddr3.c: Fix 'if' condition identical branches ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/33270/1/src/device/dram/ddr3.c File src/device/dram/ddr3.c:
https://review.coreboot.org/#/c/33270/1/src/device/dram/ddr3.c@185 PS1, Line 185: printk(RAM_DEBUG, " Capacity : %u Mb\n", 256 << capacity_shift); line over 80 characters
https://review.coreboot.org/#/c/33270/1/src/device/dram/ddr3.c@187 PS1, Line 187: printk(RAM_DEBUG, " Capacity : %u Gb\n", 1 << (capacity_shift - 2)); line over 80 characters
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33270 )
Change subject: src/device/dram/ddr3.c: Fix 'if' condition identical branches ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/#/c/33270/2/src/device/dram/ddr3.c File src/device/dram/ddr3.c:
https://review.coreboot.org/#/c/33270/2/src/device/dram/ddr3.c@185 PS2, Line 185: printk(RAM_DEBUG, " Capacity : %u Mb\n", 256 << capacity_shift); line over 80 characters
https://review.coreboot.org/#/c/33270/2/src/device/dram/ddr3.c@187 PS2, Line 187: printk(RAM_DEBUG, " Capacity : %u Gb\n", 1 << (capacity_shift - 2)); line over 80 characters
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/33270 )
Change subject: src/device/dram/ddr3.c: Fix 'if' condition identical branches ......................................................................
Abandoned
we can't use printk
-
build bot (Jenkins) (Code Review) -
HAOUAS Elyes (Code Review)