Attention is currently required from: Bora Guvendik, Raul Rangel, Nico Huber, Cliff Huang, Selma Bensaid, Paul Menzel.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62301 )
Change subject: drivers/pcie/generic: Add support to generate code under companion device instead
......................................................................
Patch Set 5:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62301/comment/02b1feb7_04820346
PS5, Line 11: to th
with the
Patchset:
PS5:
so the problem this patch should solve is when there are multiple drivers that add acpi code to a device, right? not sure if adding a setting to attach the acpi code to a different device is the best approach here
File src/drivers/pcie/generic/chip.h:
https://review.coreboot.org/c/coreboot/+/62301/comment/3b190ef3_d24f09a7
PS5, Line 10: DEVTREE_CONST struct device *companion_dev;
would be helpful to have a comment here to know what the companion_dev is about without having to look into the code that uses this struct element
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62301
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I80634bbfc2927f26f2a55a9c244eca517c437079
Gerrit-Change-Number: 62301
Gerrit-PatchSet: 5
Gerrit-Owner: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Cliff Huang
cliff.huang@intel.corp-partner.google.com
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Mon, 07 Mar 2022 17:21:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment