Martin L Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/67347 )
Change subject: util/lint/checkpatch: check for phases in commit message. ......................................................................
util/lint/checkpatch: check for phases in commit message.
The phase names shouldn't be used in the commit message, so add a gentle reminder in checkpatch. This can be ignored so if it's not needed, no harm done.
Signed-off-by: Martin Roth gaumless@gmail.com Change-Id: Ia0fe7c75cc10926a3f4713c350c39af11b62bbae --- M util/lint/checkpatch.pl 1 file changed, 22 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/67347/1
diff --git a/util/lint/checkpatch.pl b/util/lint/checkpatch.pl index 650ddff..5f17aeb 100755 --- a/util/lint/checkpatch.pl +++ b/util/lint/checkpatch.pl @@ -2938,6 +2938,14 @@ } }
+# coreboot: Check for project phase names in commit message +# Phase names should generally not be referenced to keep the project timelines private + if ($in_header_lines && + ($line =~ /\s(proto\d?|evt|dvt|pvt)\s/i) { + WARN("COMMIT_LOG_PHASE_NAME", + "Commit message should generally not include phases.\n" . $herecurr); + } + # Reset possible stack dump if a blank line is found if ($in_commit_log && $commit_log_possible_stack_dump && $line =~ /^\s*$/) {