Attention is currently required from: Jason Glenesk, Marshall Dawson, Kangheui Won, Felix Held.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59866 )
Change subject: amdfwtool: Add options to separate signed firmwares
......................................................................
Patch Set 2:
(1 comment)
File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/59866/comment/0c6d3837_2f86f2c6
PS2, Line 825: pspdir->entries[count].addr = fw_table[i].addr_signed;
: bytes = fw_table[i].file_size;
Why is the address & size being tracked?
Same for unsigned firmware. I am seeing that the blob is copied into mirror buffer. If so, why is the address being tracked there?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59866
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9f3610a7002b2a9c70946b083b0b3be6934200b0
Gerrit-Change-Number: 59866
Gerrit-PatchSet: 2
Gerrit-Owner: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Bao Zheng
fishbaozi@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Kangheui Won
khwon@chromium.org
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 22 Dec 2021 00:46:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment