Attention is currently required from: Naveen M, Pranava Y N, Subrata Banik.
Hello Naveen M,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/85440?usp=email
to review the following change.
Change subject: mb/google/fatcat: Update Soundwire codec address based on devicetree ......................................................................
mb/google/fatcat: Update Soundwire codec address based on devicetree
BUG=b:368495490 TEST=build coreboot image and boot on google fatcat. Disassemble SSDT and confirm ACPI entries are correct for alc7xx device.
Change-Id: I3322ae2d106d3628dbf627aacf999056d82ee7a9 Signed-off-by: Varun Upadhyay varun.upadhyay@intel.com Signed-off-by: Naveen M naveen.m@intel.com --- M src/mainboard/google/fatcat/Kconfig M src/mainboard/google/fatcat/variants/fatcat/overridetree.cb 2 files changed, 3 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/85440/1
diff --git a/src/mainboard/google/fatcat/Kconfig b/src/mainboard/google/fatcat/Kconfig index 1851cde..351caff 100644 --- a/src/mainboard/google/fatcat/Kconfig +++ b/src/mainboard/google/fatcat/Kconfig @@ -10,7 +10,7 @@ select DRIVERS_INTEL_SOUNDWIRE select DRIVERS_WWAN_FM350GL select DRIVERS_AUDIO_SOF - select DRIVERS_SOUNDWIRE_ALC722 + select DRIVERS_SOUNDWIRE_ALC_BASE_7XX select DRIVERS_SPI_ACPI select DUMP_SMBIOS_TYPE17 select EC_ACPI diff --git a/src/mainboard/google/fatcat/variants/fatcat/overridetree.cb b/src/mainboard/google/fatcat/variants/fatcat/overridetree.cb index 0fd79d0..ac1970f 100644 --- a/src/mainboard/google/fatcat/variants/fatcat/overridetree.cb +++ b/src/mainboard/google/fatcat/variants/fatcat/overridetree.cb @@ -622,10 +622,12 @@ # SoundWire Link 1 ID 1 register "desc" = ""Headset Codec"" device generic 1.1 on + register "alc711_address[1].part_id" = "0x0722" probe AUDIO AUDIO_ALC722_SNDW end # SoundWire Link 3 ID 1 device generic 3.1 on + register "alc711_address[3].part_id" = "0x0721" probe AUDIO AUDIO_ALC721_SNDW end end